zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

[Embeds] stop adding tracking params to non-bsky.app links (#4167)

Browse source 
* don't add tracking params on non-bsky.app links

* validate facets
This commit is contained in:
Samuel Newman 2024-05-23 03:52:46 +01:00 • committed by GitHub
parent 69f4684859
commit 334483ad9a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 37 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
bskyembed/src/screens/landing.tsx
View file

@ -112,7 +112,7 @@ function LandingPage() {
<Link
href="https://bsky.social/about"
className="transition-transform hover:scale-110">
<img src={logo as string} className="h-10" />
<img src={logo} className="h-10" />
</Link>
<h1 className="text-4xl font-bold text-center">Embed a Bluesky Post</h1>
@ -125,7 +125,7 @@ function LandingPage() {
placeholder={DEFAULT_POST}
/>
<img src={arrowBottom as string} className="w-6" />
<img src={arrowBottom} className="w-6" />
{loading ? (
<Skeleton />

4
bskyembed/src/screens/post.tsx
View file

@ -52,7 +52,7 @@ function PwiOptOut({thread}: {thread: AppBskyFeedDefs.ThreadViewPost}) {
<Link
href={href}
className="transition-transform hover:scale-110 absolute top-4 right-4">
<img src={logo as string} className="h-6" />
<img src={logo} className="h-6" />
</Link>
<div className="w-full py-12 gap-4 flex flex-col items-center">
<p className="max-w-80 text-center w-full text-textLight">
@ -75,7 +75,7 @@ function ErrorMessage() {
<Link
href="https://bsky.app/"
className="transition-transform hover:scale-110 absolute top-4 right-4">
<img src={logo as string} className="h-6" />
<img src={logo} className="h-6" />
</Link>
<p className="my-16 text-center w-full text-textLight">
Post not found, it may have been deleted.