zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Remove useEffect from TimeElapsed (#3741)

Browse source
This commit is contained in:
dan 2024-04-28 22:37:00 +01:00 • committed by GitHub
parent 256bb33de0
commit 361d255e95
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/view/com/util/TimeElapsed.tsx
View file

@ -3,8 +3,6 @@ import React from 'react'
import {useTickEveryMinute} from '#/state/shell' import {useTickEveryMinute} from '#/state/shell'
import {ago} from 'lib/strings/time' import {ago} from 'lib/strings/time'
// FIXME(dan): Figure out why the false positives
export function TimeElapsed({ export function TimeElapsed({
timestamp, timestamp,
children, children,
@ -15,9 +13,11 @@ export function TimeElapsed({
const tick = useTickEveryMinute() const tick = useTickEveryMinute()
const [timeElapsed, setTimeAgo] = React.useState(() => ago(timestamp)) const [timeElapsed, setTimeAgo] = React.useState(() => ago(timestamp))
React.useEffect(() => { const [prevTick, setPrevTick] = React.useState(tick)
if (prevTick !== tick) {
setPrevTick(tick)
setTimeAgo(ago(timestamp)) setTimeAgo(ago(timestamp))
}, [timestamp, setTimeAgo, tick]) }
return children({timeElapsed}) return children({timeElapsed})
} }