zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Fix thread positioning on load (#1385) 

* Fix minIndex for consistent positioning on thread view

* Enable maintainVisibleContentPosition on android now that it's supported
zio/stable
Paul Frazee 2023-09-05 13:40:38 -07:00 committed by GitHub
parent e3e91816d1
commit 411c1581f6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/view/com/post-thread/PostThread.tsx
View File

@ -22,7 +22,7 @@ import {ViewHeader} from '../util/ViewHeader'
import {ErrorMessage} from '../util/error/ErrorMessage' import {ErrorMessage} from '../util/error/ErrorMessage'
import {Text} from '../util/text/Text' import {Text} from '../util/text/Text'
import {s} from 'lib/styles' import {s} from 'lib/styles'
import {isIOS, isDesktopWeb} from 'platform/detection' import {isNative, isDesktopWeb} from 'platform/detection'
import {usePalette} from 'lib/hooks/usePalette' import {usePalette} from 'lib/hooks/usePalette'
import {useSetTitle} from 'lib/hooks/useSetTitle' import {useSetTitle} from 'lib/hooks/useSetTitle'
import {useNavigation} from '@react-navigation/native' import {useNavigation} from '@react-navigation/native'
@ -30,7 +30,7 @@ import {useWebMediaQueries} from 'lib/hooks/useWebMediaQueries'
import {NavigationProp} from 'lib/routes/types' import {NavigationProp} from 'lib/routes/types'
import {sanitizeDisplayName} from 'lib/strings/display-names' import {sanitizeDisplayName} from 'lib/strings/display-names'
const MAINTAIN_VISIBLE_CONTENT_POSITION = {minIndexForVisible: 0} const MAINTAIN_VISIBLE_CONTENT_POSITION = {minIndexForVisible: 2}
const TOP_COMPONENT = { const TOP_COMPONENT = {
_reactKey: '__top_component__', _reactKey: '__top_component__',
@ -311,7 +311,7 @@ export const PostThread = observer(function PostThread({
data={posts} data={posts}
initialNumToRender={posts.length} initialNumToRender={posts.length}
maintainVisibleContentPosition={ maintainVisibleContentPosition={
isIOS && view.isFromCache isNative && view.isFromCache
? MAINTAIN_VISIBLE_CONTENT_POSITION ? MAINTAIN_VISIBLE_CONTENT_POSITION
: undefined : undefined
} }
@ -326,7 +326,7 @@ export const PostThread = observer(function PostThread({
/> />
} }
onContentSizeChange={ onContentSizeChange={
isIOS && view.isFromCache ? undefined : onContentSizeChange isNative && view.isFromCache ? undefined : onContentSizeChange
} }
onScrollToIndexFailed={onScrollToIndexFailed} onScrollToIndexFailed={onScrollToIndexFailed}
style={s.hContentRegion} style={s.hContentRegion}