Fix List onMomentumScrollEnd (#3759)

src/view/com/post-thread/PostThread.tsx

@@ -1,10 +1,12 @@
 import React, {useEffect, useRef} from 'react'
 import {StyleSheet, useWindowDimensions, View} from 'react-native'
+import {runOnJS} from 'react-native-reanimated'
 import {AppBskyFeedDefs} from '@atproto/api'
 import {msg, Trans} from '@lingui/macro'
 import {useLingui} from '@lingui/react'
 
 import {moderatePost_wrapped as moderatePost} from '#/lib/moderatePost_wrapped'
+import {ScrollProvider} from '#/lib/ScrollContext'
 import {isAndroid, isNative, isWeb} from '#/platform/detection'
 import {
   sortThread,
@@ -276,8 +278,11 @@ export function PostThread({
       setMaxParents(n => n + PARENTS_CHUNK_SIZE)
     }
   }, [])
-  const onMomentumScrollEnd = bumpMaxParentsIfNeeded
   const onScrollToTop = bumpMaxParentsIfNeeded
+  const onMomentumEnd = React.useCallback(() => {
+    'worklet'
+    runOnJS(bumpMaxParentsIfNeeded)()
+  }, [bumpMaxParentsIfNeeded])
 
   const onEndReached = React.useCallback(() => {
     if (isFetching || posts.length < maxReplies) return
@@ -382,38 +387,39 @@ export function PostThread({
   }
 
   return (
-    <List
+    <ScrollProvider onMomentumEnd={onMomentumEnd}>
-      ref={ref}
+      <List
-      data={posts}
+        ref={ref}
-      renderItem={renderItem}
+        data={posts}
-      keyExtractor={keyExtractor}
+        renderItem={renderItem}
-      onContentSizeChange={isNative ? undefined : onContentSizeChangeWeb}
+        keyExtractor={keyExtractor}
-      onStartReached={onStartReached}
+        onContentSizeChange={isNative ? undefined : onContentSizeChangeWeb}
-      onEndReached={onEndReached}
+        onStartReached={onStartReached}
-      onEndReachedThreshold={2}
+        onEndReached={onEndReached}
-      onMomentumScrollEnd={onMomentumScrollEnd}
+        onEndReachedThreshold={2}
-      onScrollToTop={onScrollToTop}
+        onScrollToTop={onScrollToTop}
-      maintainVisibleContentPosition={
+        maintainVisibleContentPosition={
-        isNative ? MAINTAIN_VISIBLE_CONTENT_POSITION : undefined
+          isNative ? MAINTAIN_VISIBLE_CONTENT_POSITION : undefined
-      }
+        }
-      // @ts-ignore our .web version only -prf
+        // @ts-ignore our .web version only -prf
-      desktopFixedHeight
+        desktopFixedHeight
-      removeClippedSubviews={isAndroid ? false : undefined}
+        removeClippedSubviews={isAndroid ? false : undefined}
-      ListFooterComponent={
+        ListFooterComponent={
-        <ListFooter
+          <ListFooter
-          // Using `isFetching` over `isFetchingNextPage` is done on purpose here so we get the loader on
+            // Using `isFetching` over `isFetchingNextPage` is done on purpose here so we get the loader on
-          // initial render
+            // initial render
-          isFetchingNextPage={isFetching}
+            isFetchingNextPage={isFetching}
-          error={cleanError(threadError)}
+            error={cleanError(threadError)}
-          onRetry={refetch}
+            onRetry={refetch}
-          // 300 is based on the minimum height of a post. This is enough extra height for the `maintainVisPos` to
+            // 300 is based on the minimum height of a post. This is enough extra height for the `maintainVisPos` to
-          // work without causing weird jumps on web or glitches on native
+            // work without causing weird jumps on web or glitches on native
-          height={windowHeight - 200}
+            height={windowHeight - 200}
-        />
+          />
-      }
+        }
-      initialNumToRender={initialNumToRender}
+        initialNumToRender={initialNumToRender}
-      windowSize={11}
+        windowSize={11}
-    />
+      />
+    </ScrollProvider>
   )
 }
 

src/view/com/util/List.tsx

@@ -13,7 +13,11 @@ import {FlatList_INTERNAL} from './Views'
 export type ListMethods = FlatList_INTERNAL
 export type ListProps<ItemT> = Omit<
   FlatListProps<ItemT>,
+  | 'onMomentumScrollBegin' // Use ScrollContext instead.
+  | 'onMomentumScrollEnd' // Use ScrollContext instead.
   | 'onScroll' // Use ScrollContext instead.
+  | 'onScrollBeginDrag' // Use ScrollContext instead.
+  | 'onScrollEndDrag' // Use ScrollContext instead.
   | 'refreshControl' // Pass refreshing and/or onRefresh instead.
   | 'contentOffset' // Pass headerOffset instead.
 > & {