zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Improve error logging

Browse source
This commit is contained in:
Paul Frazee 2023-01-02 21:39:15 -06:00
parent 6885fb2b41
commit 4eabc2d65a
49 changed files with 212 additions and 188 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/view/com/composer/PhotoCarouselPicker.tsx
View file

@ -40,7 +40,7 @@ export const PhotoCarouselPicker = ({
onSelectPhotos([uri, ...selectedPhotos])
} catch (err: any) {
// ignore
store.log.warn('Error using camera', err.toString())
store.log.warn('Error using camera', err)
}
}, [store.log, selectedPhotos, onSelectPhotos])
@ -56,7 +56,7 @@ export const PhotoCarouselPicker = ({
onSelectPhotos([finalUri, ...selectedPhotos])
} catch (err: any) {
// ignore
store.log.warn('Error selecting photo', err.toString())
store.log.warn('Error selecting photo', err)
}
},
[store.log, selectedPhotos, onSelectPhotos],

8
src/view/com/discover/SuggestedFollows.tsx
View file

@ -45,7 +45,7 @@ export const SuggestedFollows = observer(
view
.setup()
.catch((err: any) =>
store.log.error('Failed to fetch suggestions', err.toString()),
store.log.error('Failed to fetch suggestions', err),
)
}, [view, store.log])
@ -59,7 +59,7 @@ export const SuggestedFollows = observer(
view
.setup()
.catch((err: any) =>
store.log.error('Failed to fetch suggestions', err.toString()),
store.log.error('Failed to fetch suggestions', err),
)
const onPressFollow = async (item: SuggestedActor) => {
@ -67,7 +67,7 @@ export const SuggestedFollows = observer(
const res = await apilib.follow(store, item.did, item.declaration.cid)
setFollows({[item.did]: res.uri, ...follows})
} catch (e: any) {
store.log.error('Failed fo create follow', {error: e.toString(), item})
store.log.error('Failed fo create follow', e)
Toast.show('An issue occurred, please try again.')
}
}
@ -76,7 +76,7 @@ export const SuggestedFollows = observer(
await apilib.unfollow(store, follows[item.did])
setFollows(_omit(follows, [item.did]))
} catch (e: any) {
store.log.error('Failed fo delete follow', {error: e.toString(), item})
store.log.error('Failed fo delete follow', e)
Toast.show('An issue occurred, please try again.')
}
}

4
src/view/com/login/CreateAccount.tsx
View file

@ -54,7 +54,7 @@ export const CreateAccount = ({onPressBack}: {onPressBack: () => void}) => {
if (aborted) return
store.log.warn(
`Failed to fetch service description for ${serviceUrl}`,
err.toString(),
err,
)
setError(
'Unable to contact your service. Please check your Internet connection.',
@ -100,7 +100,7 @@ export const CreateAccount = ({onPressBack}: {onPressBack: () => void}) => {
errMsg =
'Invite code not accepted. Check that you input it correctly and try again.'
}
store.log.warn('Failed to create account', e.toString())
store.log.error('Failed to create account', e)
setIsProcessing(false)
setError(errMsg.replace(/^Error:/, ''))
}

8
src/view/com/login/Signin.tsx
View file

@ -53,7 +53,7 @@ export const Signin = ({onPressBack}: {onPressBack: () => void}) => {
if (aborted) return
store.log.warn(
`Failed to fetch service description for ${serviceUrl}`,
err.toString(),
err,
)
setError(
'Unable to contact your service. Please check your Internet connection.',
@ -171,7 +171,7 @@ const LoginForm = ({
})
} catch (e: any) {
const errMsg = e.toString()
store.log.warn('Failed to login', e.toString())
store.log.warn('Failed to login', e)
setIsProcessing(false)
if (errMsg.includes('Authentication Required')) {
setError('Invalid username or password')
@ -307,7 +307,7 @@ const ForgotPasswordForm = ({
onEmailSent()
} catch (e: any) {
const errMsg = e.toString()
store.log.warn('Failed to request password reset', e.toString())
store.log.warn('Failed to request password reset', e)
setIsProcessing(false)
if (isNetworkError(e)) {
setError(
@ -419,7 +419,7 @@ const SetNewPasswordForm = ({
onPasswordSet()
} catch (e: any) {
const errMsg = e.toString()
store.log.warn('Failed to set new password', e.toString())
store.log.warn('Failed to set new password', e)
setIsProcessing(false)
if (isNetworkError(e)) {
setError(

12
src/view/com/modals/CreateScene.tsx
View file

@ -57,10 +57,7 @@ export function Component({}: {}) {
})
.catch(e =>
// an error here is not critical
store.log.error(
'Failed to update scene profile during creation',
e.toString(),
),
store.log.error('Failed to update scene profile during creation', e),
)
// follow the scene
await store.api.app.bsky.graph.follow
@ -78,10 +75,7 @@ export function Component({}: {}) {
)
.catch(e =>
// an error here is not critical
store.log.error(
'Failed to follow scene after creation',
e.toString(),
),
store.log.error('Failed to follow scene after creation', e),
)
Toast.show('Scene created')
store.shell.closeModal()
@ -94,7 +88,7 @@ export function Component({}: {}) {
} else if (e instanceof AppBskyActorCreateScene.HandleNotAvailableError) {
setError(`The handle "${handle}" is not available.`)
} else {
store.log.error('Failed to create scene', e.toString())
store.log.error('Failed to create scene', e)
setError(
'Failed to create the scene. Check your internet connection and try again.',
)

6
src/view/com/modals/InviteToScene.tsx
View file

@ -86,7 +86,7 @@ export const Component = observer(function Component({
Toast.show('Invite sent')
} catch (e: any) {
setError('There was an issue with the invite. Please try again.')
store.log.error('Failed to invite user to scene', e.toString())
store.log.error('Failed to invite user to scene', e)
}
}
const onPressUndo = async (subjectDid: string, assertionUri: string) => {
@ -100,7 +100,7 @@ export const Component = observer(function Component({
setCreatedInvites(_omit(createdInvites, [subjectDid]))
} catch (e: any) {
setError('There was an issue with the invite. Please try again.')
store.log.error('Failed to delete a scene invite', e.toString())
store.log.error('Failed to delete a scene invite', e)
}
}
@ -119,7 +119,7 @@ export const Component = observer(function Component({
Toast.show('Invite removed')
} catch (e: any) {
setError('There was an issue with the invite. Please try again.')
store.log.error('Failed to delete an invite', e.toString())
store.log.error('Failed to delete an invite', e)
}
}

10
src/view/com/notifications/Feed.tsx
View file

@ -39,20 +39,14 @@ export const Feed = observer(function Feed({
view
.refresh()
.catch(err =>
view.rootStore.log.error(
'Failed to refresh notifications feed',
err.toString(),
),
view.rootStore.log.error('Failed to refresh notifications feed', err),
)
}
const onEndReached = () => {
view
.loadMore()
.catch(err =>
view.rootStore.log.error(
'Failed to load more notifications',
err.toString(),
),
view.rootStore.log.error('Failed to load more notifications', err),
)
}
let data

4
src/view/com/post-thread/PostRepostedBy.tsx
View file

@ -28,9 +28,7 @@ export const PostRepostedBy = observer(function PostRepostedBy({
setView(newView)
newView
.setup()
.catch(err =>
store.log.error('Failed to fetch reposted by', err.toString()),
)
.catch(err => store.log.error('Failed to fetch reposted by', err))
}, [uri, view?.params.uri, store])
const onRefresh = () => {

5
src/view/com/post-thread/PostThread.tsx
View file

@ -21,10 +21,7 @@ export const PostThread = observer(function PostThread({
view
?.refresh()
.catch(err =>
view.rootStore.log.error(
'Failed to refresh posts thread',
err.toString(),
),
view.rootStore.log.error('Failed to refresh posts thread', err),
)
}
const onLayout = () => {

6
src/view/com/post-thread/PostThreadItem.tsx
View file

@ -72,12 +72,12 @@ export const PostThreadItem = observer(function PostThreadItem({
const onPressToggleRepost = () => {
item
.toggleRepost()
.catch(e => store.log.error('Failed to toggle repost', e.toString()))
.catch(e => store.log.error('Failed to toggle repost', e))
}
const onPressToggleUpvote = () => {
item
.toggleUpvote()
.catch(e => store.log.error('Failed to toggle upvote', e.toString()))
.catch(e => store.log.error('Failed to toggle upvote', e))
}
const onCopyPostText = () => {
Clipboard.setString(record.text)
@ -90,7 +90,7 @@ export const PostThreadItem = observer(function PostThreadItem({
Toast.show('Post deleted')
},
e => {
store.log.error('Failed to delete post', e.toString())
store.log.error('Failed to delete post', e)
Toast.show('Failed to delete post, please try again')
},
)

2
src/view/com/post-thread/PostVotedBy.tsx
View file

@ -30,7 +30,7 @@ export const PostVotedBy = observer(function PostVotedBy({
setView(newView)
newView
.setup()
.catch(err => store.log.error('Failed to fetch voted by', err.toString()))
.catch(err => store.log.error('Failed to fetch voted by', err))
}, [uri, view?.params.uri, store])
const onRefresh = () => {

10
src/view/com/post/Post.tsx
View file

@ -47,9 +47,7 @@ export const Post = observer(function Post({
}
const newView = new PostThreadViewModel(store, {uri, depth: 0})
setView(newView)
newView
.setup()
.catch(err => store.log.error('Failed to fetch post', err.toString()))
newView.setup().catch(err => store.log.error('Failed to fetch post', err))
}, [initView, uri, view?.params.uri, store])
// deleted
@ -112,12 +110,12 @@ export const Post = observer(function Post({
const onPressToggleRepost = () => {
item
.toggleRepost()
.catch(e => store.log.error('Failed to toggle repost', e.toString()))
.catch(e => store.log.error('Failed to toggle repost', e))
}
const onPressToggleUpvote = () => {
item
.toggleUpvote()
.catch(e => store.log.error('Failed to toggle upvote', e.toString()))
.catch(e => store.log.error('Failed to toggle upvote', e))
}
const onCopyPostText = () => {
Clipboard.setString(record.text)
@ -130,7 +128,7 @@ export const Post = observer(function Post({
Toast.show('Post deleted')
},
e => {
store.log.error('Failed to delete post', e.toString())
store.log.error('Failed to delete post', e)
Toast.show('Failed to delete post, please try again')
},
)

4
src/view/com/post/PostText.tsx
View file

@ -23,9 +23,7 @@ export const PostText = observer(function PostText({
}
const newModel = new PostModel(store, uri)
setModel(newModel)
newModel
.setup()
.catch(err => store.log.error('Failed to fetch post', err.toString()))
newModel.setup().catch(err => store.log.error('Failed to fetch post', err))
}, [uri, model?.uri, store])
// loading

9
src/view/com/posts/Feed.tsx
View file

@ -56,18 +56,13 @@ export const Feed = observer(function Feed({
feed
.refresh()
.catch(err =>
feed.rootStore.log.error(
'Failed to refresh posts feed',
err.toString(),
),
feed.rootStore.log.error('Failed to refresh posts feed', err),
)
}
const onEndReached = () => {
feed
.loadMore()
.catch(err =>
feed.rootStore.log.error('Failed to load more posts', err.toString()),
)
.catch(err => feed.rootStore.log.error('Failed to load more posts', err))
}
let data
if (feed.hasLoaded) {

6
src/view/com/posts/FeedItem.tsx
View file

@ -69,12 +69,12 @@ export const FeedItem = observer(function ({
const onPressToggleRepost = () => {
item
.toggleRepost()
.catch(e => store.log.error('Failed to toggle repost', e.toString()))
.catch(e => store.log.error('Failed to toggle repost', e))
}
const onPressToggleUpvote = () => {
item
.toggleUpvote()
.catch(e => store.log.error('Failed to toggle upvote', e.toString()))
.catch(e => store.log.error('Failed to toggle upvote', e))
}
const onCopyPostText = () => {
Clipboard.setString(record.text)
@ -87,7 +87,7 @@ export const FeedItem = observer(function ({
Toast.show('Post deleted')
},
e => {
store.log.error('Failed to delete post', e.toString())
store.log.error('Failed to delete post', e)
Toast.show('Failed to delete post, please try again')
},
)

4
src/view/com/profile/ProfileFollowers.tsx
View file

@ -29,9 +29,7 @@ export const ProfileFollowers = observer(function ProfileFollowers({
setView(newView)
newView
.setup()
.catch(err =>
store.log.error('Failed to fetch user followers', err.toString()),
)
.catch(err => store.log.error('Failed to fetch user followers', err))
}, [name, view?.params.user, store])
const onRefresh = () => {

4
src/view/com/profile/ProfileFollows.tsx
View file

@ -29,9 +29,7 @@ export const ProfileFollows = observer(function ProfileFollows({
setView(newView)
newView
.setup()
.catch(err =>
store.log.error('Failed to fetch user follows', err.toString()),
)
.catch(err => store.log.error('Failed to fetch user follows', err))
}, [name, view?.params.user, store])
const onRefresh = () => {

6
src/view/com/profile/ProfileHeader.tsx
View file

@ -52,7 +52,7 @@ export const ProfileHeader = observer(function ProfileHeader({
}`,
)
},
err => store.log.error('Failed to toggle follow', err.toString()),
err => store.log.error('Failed to toggle follow', err),
)
}
const onPressEditProfile = () => {
@ -94,7 +94,7 @@ export const ProfileHeader = observer(function ProfileHeader({
await view.muteAccount()
Toast.show('Account muted')
} catch (e: any) {
store.log.error('Failed to mute account', e.toString())
store.log.error('Failed to mute account', e)
Toast.show(`There was an issue! ${e.toString()}`)
}
}
@ -103,7 +103,7 @@ export const ProfileHeader = observer(function ProfileHeader({
await view.unmuteAccount()
Toast.show('Account unmuted')
} catch (e: any) {
store.log.error('Failed to unmute account', e.toString())
store.log.error('Failed to unmute account', e)
Toast.show(`There was an issue! ${e.toString()}`)
}
}

2
src/view/com/profile/ProfileMembers.tsx
View file

@ -22,7 +22,7 @@ export const ProfileMembers = observer(function ProfileMembers({
setView(newView)
newView
.setup()
.catch(err => store.log.error('Failed to fetch members', err.toString()))
.catch(err => store.log.error('Failed to fetch members', err))
}, [name, view?.params.actor, store])
const onRefresh = () => {