Disable newskie dialog tap in hover card web (#4562)

zio/stable
Eric Bailey 2024-06-18 14:09:40 -05:00 committed by GitHub
parent d6ce16d15a
commit 502bcad701
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 3 deletions

View File

@ -18,8 +18,10 @@ import {Text} from '#/components/Typography'
export function NewskieDialog({ export function NewskieDialog({
profile, profile,
disabled,
}: { }: {
profile: AppBskyActorDefs.ProfileViewDetailed profile: AppBskyActorDefs.ProfileViewDetailed
disabled?: boolean
}) { }) {
const {_} = useLingui() const {_} = useLingui()
const moderationOpts = useModerationOpts() const moderationOpts = useModerationOpts()
@ -43,6 +45,7 @@ export function NewskieDialog({
return ( return (
<View style={[a.pr_2xs]}> <View style={[a.pr_2xs]}>
<Button <Button
disabled={disabled}
label={_( label={_(
msg`This user is new here. Press for more info about when they joined.`, msg`This user is new here. Press for more info about when they joined.`,
)} )}

View File

@ -469,7 +469,7 @@ function Inner({
)} )}
</Text> </Text>
<ProfileHeaderHandle profile={profileShadow} /> <ProfileHeaderHandle profile={profileShadow} disableTaps />
</View> </View>
</Link> </Link>

View File

@ -12,8 +12,10 @@ import {Text} from '#/components/Typography'
export function ProfileHeaderHandle({ export function ProfileHeaderHandle({
profile, profile,
disableTaps,
}: { }: {
profile: Shadow<AppBskyActorDefs.ProfileViewDetailed> profile: Shadow<AppBskyActorDefs.ProfileViewDetailed>
disableTaps?: boolean
}) { }) {
const t = useTheme() const t = useTheme()
const invalidHandle = isInvalidHandle(profile.handle) const invalidHandle = isInvalidHandle(profile.handle)
@ -21,8 +23,8 @@ export function ProfileHeaderHandle({
return ( return (
<View <View
style={[a.flex_row, a.gap_xs, a.align_center]} style={[a.flex_row, a.gap_xs, a.align_center]}
pointerEvents={isAndroid ? 'box-only' : 'auto'}> pointerEvents={disableTaps ? 'none' : isAndroid ? 'box-only' : 'auto'}>
<NewskieDialog profile={profile} /> <NewskieDialog profile={profile} disabled={disableTaps} />
{profile.viewer?.followedBy && !blockHide ? ( {profile.viewer?.followedBy && !blockHide ? (
<View style={[t.atoms.bg_contrast_25, a.rounded_xs, a.px_sm, a.py_xs]}> <View style={[t.atoms.bg_contrast_25, a.rounded_xs, a.px_sm, a.py_xs]}>
<Text style={[t.atoms.text, a.text_sm]}> <Text style={[t.atoms.text, a.text_sm]}>