zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Move onboarding start to after successfull account creation (#4381) 

* Move onboarding start to after successfull account creation

* Remove unused dispatch
zio/stable
Eric Bailey 2024-06-18 18:46:34 -05:00 committed by GitHub
parent 07c2be255f
commit 5159495274
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/screens/Signup/state.ts
View File

@ -252,7 +252,6 @@ export function useSubmitSignup({
dispatch({type: 'setIsLoading', value: true}) dispatch({type: 'setIsLoading', value: true})
try { try {
onboardingDispatch({type: 'start'}) // start now to avoid flashing the wrong view
await createAccount({ await createAccount({
service: state.serviceUrl, service: state.serviceUrl,
email: state.email, email: state.email,
@ -262,8 +261,12 @@ export function useSubmitSignup({
inviteCode: state.inviteCode.trim(), inviteCode: state.inviteCode.trim(),
verificationCode: verificationCode, verificationCode: verificationCode,
}) })
/*
* Must happen last so that if the user has multiple tabs open and
* createAccount fails, one tab is not stuck in onboarding — Eric
*/
onboardingDispatch({type: 'start'})
} catch (e: any) { } catch (e: any) {
onboardingDispatch({type: 'skip'}) // undo starting the onboard
let errMsg = e.toString() let errMsg = e.toString()
if (e instanceof ComAtprotoServerCreateAccount.InvalidInviteCodeError) { if (e instanceof ComAtprotoServerCreateAccount.InvalidInviteCodeError) {
dispatch({ dispatch({