[🐴] Reorg convo files (#3909)

* Remove unused prop

* Reorganize
This commit is contained in:
Eric Bailey 2024-05-07 21:46:59 -05:00 committed by GitHub
parent 814ec2bd7f
commit 56f713077f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 296 additions and 278 deletions

View file

@ -3,7 +3,7 @@ import {View} from 'react-native'
import {msg} from '@lingui/macro'
import {useLingui} from '@lingui/react'
import {ConvoItem, ConvoItemError} from '#/state/messages/convo'
import {ConvoItem, ConvoItemError} from '#/state/messages/convo/types'
import {atoms as a, useTheme} from '#/alf'
import {CircleInfo_Stroke2_Corner0_Rounded as CircleInfo} from '#/components/icons/CircleInfo'
import {InlineLinkText} from '#/components/Link'

View file

@ -11,8 +11,8 @@ import {msg, Trans} from '@lingui/macro'
import {useLingui} from '@lingui/react'
import {isIOS} from '#/platform/detection'
import {useChat} from '#/state/messages'
import {ConvoItem, ConvoStatus} from '#/state/messages/convo'
import {useConvo} from '#/state/messages/convo'
import {ConvoItem, ConvoStatus} from '#/state/messages/convo/types'
import {ScrollProvider} from 'lib/ScrollContext'
import {isWeb} from 'platform/detection'
import {List} from 'view/com/util/List'
@ -86,7 +86,7 @@ function onScrollToIndexFailed() {
}
export function MessagesList() {
const chat = useChat()
const convo = useConvo()
const flatListRef = useRef<FlatList>(null)
// We need to keep track of when the scroll offset is at the bottom of the list to know when to scroll as new items
@ -153,20 +153,20 @@ export function MessagesList() {
// The check for `hasInitiallyScrolled` prevents an initial fetch on mount. FlatList triggers `onStartReached`
// immediately on mount, since we are in fact at an offset of zero, so we have to ignore those initial calls.
const onStartReached = useCallback(() => {
if (chat.status === ConvoStatus.Ready && hasInitiallyScrolled) {
chat.fetchMessageHistory()
if (convo.status === ConvoStatus.Ready && hasInitiallyScrolled) {
convo.fetchMessageHistory()
}
}, [chat, hasInitiallyScrolled])
}, [convo, hasInitiallyScrolled])
const onSendMessage = useCallback(
(text: string) => {
if (chat.status === ConvoStatus.Ready) {
chat.sendMessage({
if (convo.status === ConvoStatus.Ready) {
convo.sendMessage({
text,
})
}
},
[chat],
[convo],
)
const onScroll = React.useCallback(
@ -229,7 +229,7 @@ export function MessagesList() {
<ScrollProvider onScroll={onScroll} onMomentumEnd={onMomentumEnd}>
<List
ref={flatListRef}
data={chat.items}
data={convo.items}
renderItem={renderItem}
keyExtractor={keyExtractor}
disableVirtualization={true}
@ -248,7 +248,7 @@ export function MessagesList() {
onScrollToIndexFailed={onScrollToIndexFailed}
scrollEventThrottle={100}
ListHeaderComponent={
<MaybeLoader isLoading={chat.isFetchingHistory} />
<MaybeLoader isLoading={convo.isFetchingHistory} />
}
/>
</ScrollProvider>

View file

@ -13,8 +13,8 @@ import {useGate} from '#/lib/statsig/statsig'
import {useCurrentConvoId} from '#/state/messages/current-convo-id'
import {BACK_HITSLOP} from 'lib/constants'
import {isWeb} from 'platform/detection'
import {ChatProvider, useChat} from 'state/messages'
import {ConvoStatus} from 'state/messages/convo'
import {ConvoProvider, useConvo} from 'state/messages/convo'
import {ConvoStatus} from 'state/messages/convo/types'
import {PreviewableUserAvatar} from 'view/com/util/UserAvatar'
import {CenteredView} from 'view/com/util/Views'
import {MessagesList} from '#/screens/Messages/Conversation/MessagesList'
@ -46,23 +46,23 @@ export function MessagesConversationScreen({route}: Props) {
if (!gate('dms')) return <ClipClopGate />
return (
<ChatProvider convoId={convoId}>
<ConvoProvider convoId={convoId}>
<Inner />
</ChatProvider>
</ConvoProvider>
)
}
function Inner() {
const chat = useChat()
const convo = useConvo()
if (
chat.status === ConvoStatus.Uninitialized ||
chat.status === ConvoStatus.Initializing
convo.status === ConvoStatus.Uninitialized ||
convo.status === ConvoStatus.Initializing
) {
return <ListMaybePlaceholder isLoading />
}
if (chat.status === ConvoStatus.Error) {
if (convo.status === ConvoStatus.Error) {
// TODO
return (
<View>
@ -71,7 +71,7 @@ function Inner() {
<Button
label="Retry"
onPress={() => {
chat.error.retry()
convo.error.retry()
}}>
<ButtonText>Retry</ButtonText>
</Button>
@ -81,13 +81,13 @@ function Inner() {
}
/*
* Any other chat states (atm) are "ready" states
* Any other convo states (atm) are "ready" states
*/
return (
<KeyboardProvider>
<CenteredView style={{flex: 1}} sideBorders>
<Header profile={chat.recipients[0]} />
<Header profile={convo.recipients[0]} />
<MessagesList />
</CenteredView>
</KeyboardProvider>
@ -103,7 +103,7 @@ let Header = ({
const {_} = useLingui()
const {gtTablet} = useBreakpoints()
const navigation = useNavigation<NavigationProp>()
const chat = useChat()
const convo = useConvo()
const onPressBack = useCallback(() => {
if (isWeb) {
@ -157,9 +157,9 @@ let Header = ({
{profile.displayName}
</Text>
</View>
{chat.status === ConvoStatus.Ready ? (
{convo.status === ConvoStatus.Ready ? (
<ConvoMenu
convo={chat.convo}
convo={convo.convo}
profile={profile}
onUpdateConvo={onUpdateConvo}
currentScreen="conversation"