zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

[🐴] Don't always show notification for everything (#4083)

Browse source 
* don't always show a notification

* nit
This commit is contained in:
Hailey 2024-05-17 09:23:46 -07:00 • committed by GitHub
parent dd4c8d8e4f
commit 5e312d5f3a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/lib/hooks/useNotificationHandler.ts
View file

@ -41,7 +41,7 @@ type NotificationPayload =
} }
const DEFAULT_HANDLER_OPTIONS = { const DEFAULT_HANDLER_OPTIONS = {
shouldShowAlert: true, shouldShowAlert: false,
shouldPlaySound: false, shouldPlaySound: false,
shouldSetBadge: true, shouldSetBadge: true,
} }

4
src/lib/notifications/notifications.ts
View file

@ -71,12 +71,14 @@ export function useNotificationsRegistration() {
export function useRequestNotificationsPermission() { export function useRequestNotificationsPermission() {
const gate = useGate() const gate = useGate()
const {currentAccount} = useSession()
return React.useCallback( return React.useCallback(
async (context: 'StartOnboarding' | 'AfterOnboarding' | 'Login') => { async (context: 'StartOnboarding' | 'AfterOnboarding' | 'Login') => {
const permissions = await Notifications.getPermissionsAsync() const permissions = await Notifications.getPermissionsAsync()
if ( if (
!currentAccount ||
!isNative || !isNative ||
permissions?.status === 'granted' || permissions?.status === 'granted' ||
(permissions?.status === 'denied' && !permissions?.canAskAgain) (permissions?.status === 'denied' && !permissions?.canAskAgain)
@ -107,7 +109,7 @@ export function useRequestNotificationsPermission() {
getPushToken(true) getPushToken(true)
} }
}, },
[gate], [gate, currentAccount],
) )
} }