zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Fix state lifecycle management with post-feed query, solving the duplicate key issue (#2034)

Browse source 
* Assign keys to feed slices via a counter, to enable duplicate items in the feed if needed

* Move post-feed query state into the query's page params to consistently bind their lifecycles
This commit is contained in:
Paul Frazee 2023-11-29 16:58:14 -08:00 • committed by GitHub
parent a59d235e8b
commit 630637874d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 99 additions and 91 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/lib/api/feed/merge.ts
View file

@ -180,7 +180,7 @@ class MergeFeedSource {
}
class MergeFeedSource_Following extends MergeFeedSource {
tuner = new FeedTuner()
tuner = new FeedTuner(this.feedTuners)
reset() {
super.reset()
@ -197,7 +197,7 @@ class MergeFeedSource_Following extends MergeFeedSource {
): Promise<AppBskyFeedGetTimeline.Response> {
const res = await getAgent().getTimeline({cursor, limit})
// run the tuner pre-emptively to ensure better mixing
const slices = this.tuner.tune(res.data.feed, this.feedTuners, {
const slices = this.tuner.tune(res.data.feed, {
dryRun: false,
maintainOrder: true,
})