zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Push useAnimatedScrollHandler down everywhere to work around bugs (#1866)

Browse source 
* Move useOnMainScroll handlers to leaves

* Force Feed to always take handlers

* Pass handlers from the pager
This commit is contained in:
dan 2023-11-10 19:00:46 +00:00 • committed by GitHub
parent e0e5bc8fd8
commit 65def37165
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 95 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/view/com/notifications/Feed.tsx
View file

@ -8,7 +8,8 @@ import {NotificationFeedLoadingPlaceholder} from '../util/LoadingPlaceholder'
import {ErrorMessage} from '../util/error/ErrorMessage'
import {LoadMoreRetryBtn} from '../util/LoadMoreRetryBtn'
import {EmptyState} from '../util/EmptyState'
import {OnScrollCb} from 'lib/hooks/useOnMainScroll'
import {OnScrollHandler} from 'lib/hooks/useOnMainScroll'
import {useAnimatedScrollHandler} from '#/lib/hooks/useAnimatedScrollHandler_FIXED'
import {s} from 'lib/styles'
import {usePalette} from 'lib/hooks/usePalette'
import {logger} from '#/logger'
@ -27,7 +28,7 @@ export const Feed = observer(function Feed({
view: NotificationsFeedModel
scrollElRef?: MutableRefObject<FlatList<any> | null>
onPressTryAgain?: () => void
onScroll?: OnScrollCb
onScroll?: OnScrollHandler
ListHeaderComponent?: () => JSX.Element
}) {
const pal = usePalette('default')
@ -129,6 +130,7 @@ export const Feed = observer(function Feed({
[view],
)
const scrollHandler = useAnimatedScrollHandler(onScroll || {})
return (
<View style={s.hContentRegion}>
<CenteredView>
@ -161,7 +163,7 @@ export const Feed = observer(function Feed({
}
onEndReached={onEndReached}
onEndReachedThreshold={0.6}
onScroll={onScroll}
onScroll={scrollHandler}
scrollEventThrottle={1}
contentContainerStyle={s.contentContainer}
// @ts-ignore our .web version only -prf