zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Only run "disable min shell on foregrounding" behaviour if on the home screen (#3825) 

* change useEffect to useFocusEffect

* v2 -> v3
zio/stable
Samuel Newman 2024-05-02 21:27:54 +01:00 committed by GitHub
parent 96c5db3e69
commit 6da18e3dcf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/statsig/gates.ts
View File

@ -1,7 +1,7 @@
export type Gate = export type Gate =
// Keep this alphabetic please. // Keep this alphabetic please.
| 'autoexpand_suggestions_on_profile_follow_v2' | 'autoexpand_suggestions_on_profile_follow_v2'
| 'disable_min_shell_on_foregrounding_v2' | 'disable_min_shell_on_foregrounding_v3'
| 'disable_poll_on_discover_v2' | 'disable_poll_on_discover_v2'
| 'dms' | 'dms'
| 'hide_vertical_scroll_indicators' | 'hide_vertical_scroll_indicators'

8
src/view/screens/Home.tsx
View File

@ -119,13 +119,14 @@ function HomeScreenReady({
const gate = useGate() const gate = useGate()
const mode = useMinimalShellMode() const mode = useMinimalShellMode()
const {isMobile} = useWebMediaQueries() const {isMobile} = useWebMediaQueries()
React.useEffect(() => { useFocusEffect(
React.useCallback(() => {
const listener = AppState.addEventListener('change', nextAppState => { const listener = AppState.addEventListener('change', nextAppState => {
if (nextAppState === 'active') { if (nextAppState === 'active') {
if ( if (
isMobile && isMobile &&
mode.value === 1 && mode.value === 1 &&
gate('disable_min_shell_on_foregrounding_v2') gate('disable_min_shell_on_foregrounding_v3')
) { ) {
setMinimalShellMode(false) setMinimalShellMode(false)
} }
@ -134,7 +135,8 @@ function HomeScreenReady({
return () => { return () => {
listener.remove() listener.remove()
} }
}, [setMinimalShellMode, mode, isMobile, gate]) }, [setMinimalShellMode, mode, isMobile, gate]),
)
const onPageSelected = React.useCallback( const onPageSelected = React.useCallback(
(index: number) => { (index: number) => {