feat(nvm): add support for nvm & minor actions housekeeping (#2979)

* feat: add `.nvmrc` for specifying node version

Co-Authored-By: Evandro Leopoldino Gonçalves <evandrolgoncalves@gmail.com>

* chore(deps): bump setup-node to v4

* build: use node-version-file instead of hardcoded 18.x

* chore(deps): bump nvm version

* fix: checkout before install 🎉

---------

Co-authored-by: Evandro Leopoldino Gonçalves <evandrolgoncalves@gmail.com>
zio/stable
Vinayak Kulkarni 2024-02-27 07:05:06 +05:30 committed by GitHub
parent e9ad3f552d
commit 771999761e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 13 additions and 12 deletions

View File

@ -26,9 +26,9 @@ jobs:
uses: actions/checkout@v4 uses: actions/checkout@v4
- name: 🔧 Setup Node - name: 🔧 Setup Node
uses: actions/setup-node@v3 uses: actions/setup-node@v4
with: with:
node-version: 18.x node-version-file: .nvmrc
cache: yarn cache: yarn
- name: 🔨 Setup EAS - name: 🔨 Setup EAS

View File

@ -28,9 +28,9 @@ jobs:
uses: actions/checkout@v4 uses: actions/checkout@v4
- name: 🔧 Setup Node - name: 🔧 Setup Node
uses: actions/setup-node@v3 uses: actions/setup-node@v4
with: with:
node-version: 18.x node-version-file: .nvmrc
cache: yarn cache: yarn
- name: 🔨 Setup EAS - name: 🔨 Setup EAS

View File

@ -32,12 +32,12 @@ jobs:
name: Run tests name: Run tests
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Install node 18
uses: actions/setup-node@v4
with:
node-version: 18
- name: Check out Git repository - name: Check out Git repository
uses: actions/checkout@v3 uses: actions/checkout@v3
- name: Install node
uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
- name: Yarn install - name: Yarn install
uses: Wandalen/wretry.action@master uses: Wandalen/wretry.action@master
with: with:

1
.nvmrc 100644
View File

@ -0,0 +1 @@
18

View File

@ -23,7 +23,7 @@ COPY . .
RUN mkdir --parents $NVM_DIR && \ RUN mkdir --parents $NVM_DIR && \
wget \ wget \
--output-document=/tmp/nvm-install.sh \ --output-document=/tmp/nvm-install.sh \
https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh && \ https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh && \
bash /tmp/nvm-install.sh bash /tmp/nvm-install.sh
RUN \. "$NVM_DIR/nvm.sh" && \ RUN \. "$NVM_DIR/nvm.sh" && \

View File

@ -6,9 +6,9 @@ To build the SPA bundle (`bundle.web.js`), first get a JavaScript development
environment set up. Either follow the top-level README, or something quick environment set up. Either follow the top-level README, or something quick
like: like:
# install nodejs 18 (specifically) # install nodejs
nvm install 18 nvm install
nvm use 18 nvm use
npm install --global yarn npm install --global yarn
# setup tools and deps (in top level of this repo) # setup tools and deps (in top level of this repo)