Add labels to a few missing places (#4838)

2024-07-25 18:07:15 -05:00 · 2024-07-25 18:07:15 -05:00 · 783fd351ba
parent e7b485f185
commit 783fd351ba
12 changed files with 60 additions and 18 deletions
--- a/src/components/dms/BlockedByListDialog.tsx
+++ b/src/components/dms/BlockedByListDialog.tsx
@ -42,6 +42,7 @@ export function BlockedByListDialog({
              <React.Fragment key={block.source.list.uri}>
                {i === 0 ? null : ', '}
                <InlineLinkText
+                  label={block.source.list.name}
                  to={listUriToHref(block.source.list.uri)}
                  style={[a.text_md, a.leading_snug]}>
                  {block.source.list.name}
--- a/src/components/dms/MessagesListHeader.tsx
+++ b/src/components/dms/MessagesListHeader.tsx
@ -140,6 +140,7 @@ function HeaderReady({
    userBlock?: ModerationCause
  }
 }) {
+  const {_} = useLingui()
  const t = useTheme()
  const convoState = useConvo()
  const profile = useProfileShadow(profileUnshadowed)
@ -156,6 +157,7 @@ function HeaderReady({
    <View style={[a.flex_1]}>
      <View style={[a.w_full, a.flex_row, a.align_center, a.justify_between]}>
        <Link
+          label={_(msg`View ${displayName}'s profile`)}
          style={[a.flex_row, a.align_start, a.gap_md, a.flex_1, a.pr_md]}
          to={makeProfileLink(profile)}>
          <View style={[a.pt_2xs]}>
--- a/src/components/moderation/LabelPreference.tsx
+++ b/src/components/moderation/LabelPreference.tsx
@ -174,7 +174,7 @@ export function LabelerLabelPreference({
  disabled?: boolean
  labelerDid?: string
 }) {
-  const {i18n} = useLingui()
+  const {_, i18n} = useLingui()
  const t = useTheme()
  const {gtPhone} = useBreakpoints()

@ -243,7 +243,10 @@ export function LabelerLabelPreference({
              ) : isGlobalLabel ? (
                <Trans>
                  Configured in{' '}
-                  <InlineLinkText to="/moderation" style={a.text_sm}>
+                  <InlineLinkText
+                    label={_(msg`moderation settings`)}
+                    to="/moderation"
+                    style={a.text_sm}>
                    moderation settings
                  </InlineLinkText>
                  .
--- a/src/components/moderation/LabelsOnMeDialog.tsx
+++ b/src/components/moderation/LabelsOnMeDialog.tsx
@ -128,6 +128,9 @@ function Label({
  const t = useTheme()
  const {_} = useLingui()
  const {labeler, strings} = useLabelInfo(label)
+  const sourceName = labeler
+    ? sanitizeHandle(labeler.creator.handle, '@')
+    : label.src
  return (
    <View
      style={[
@ -169,13 +172,12 @@ function Label({
            <Trans>
              Source:{' '}
              <InlineLinkText
+                label={sourceName}
                to={makeProfileLink(
                  labeler ? labeler.creator : {did: label.src, handle: ''},
                )}
                onPress={() => control.close()}>
-                {labeler
-                  ? sanitizeHandle(labeler.creator.handle, '@')
-                  : label.src}
+                {sourceName}
              </InlineLinkText>
            </Trans>
          )}
@ -203,6 +205,9 @@ function AppealForm({
  const isAccountReport = 'did' in subject
  const agent = useAgent()
  const gate = useGate()
+  const sourceName = labeler
+    ? sanitizeHandle(labeler.creator.handle, '@')
+    : label.src

  const {mutate, isPending} = useMutation({
    mutationFn: async () => {
@ -260,12 +265,13 @@ function AppealForm({
        <Trans>
          This appeal will be sent to{' '}
          <InlineLinkText
+            label={sourceName}
            to={makeProfileLink(
              labeler ? labeler.creator : {did: label.src, handle: ''},
            )}
            onPress={() => control.close()}
            style={[a.text_md, a.leading_snug]}>
-            {labeler ? sanitizeHandle(labeler.creator.handle, '@') : label.src}
+            {sourceName}
          </InlineLinkText>
          .
        </Trans>
--- a/src/screens/Moderation/index.tsx
+++ b/src/screens/Moderation/index.tsx
@ -240,7 +240,10 @@ export function ModerationScreenInner({
          )}
        </Button>
        <Divider />
-        <Link testID="moderationlistsBtn" to="/moderation/modlists">
+        <Link
+          label={_(msg`View your moderation lists`)}
+          testID="moderationlistsBtn"
+          to="/moderation/modlists">
          {state => (
            <SubItem
              title={_(msg`Moderation lists`)}
@ -252,7 +255,10 @@ export function ModerationScreenInner({
          )}
        </Link>
        <Divider />
-        <Link testID="mutedAccountsBtn" to="/moderation/muted-accounts">
+        <Link
+          label={_(msg`View your muted accounts`)}
+          testID="mutedAccountsBtn"
+          to="/moderation/muted-accounts">
          {state => (
            <SubItem
              title={_(msg`Muted accounts`)}
@ -264,7 +270,10 @@ export function ModerationScreenInner({
          )}
        </Link>
        <Divider />
-        <Link testID="blockedAccountsBtn" to="/moderation/blocked-accounts">
+        <Link
+          label={_(msg`View your blocked accounts`)}
+          testID="blockedAccountsBtn"
+          to="/moderation/blocked-accounts">
          {state => (
            <SubItem
              title={_(msg`Blocked accounts`)}
@ -356,6 +365,7 @@ export function ModerationScreenInner({
                    <Trans>
                      Adult content can only be enabled via the Web at{' '}
                      <InlineLinkText
+                        label={_(msg`The Bluesky web application`)}
                        to=""
                        onPress={evt => {
                          evt.preventDefault()
@ -569,7 +579,9 @@ function PwiOptOut() {
          </Trans>
        </Text>

-        <InlineLinkText to="https://blueskyweb.zendesk.com/hc/en-us/articles/15835264007693-Data-Privacy">
+        <InlineLinkText
+          label={_(msg`Learn more about what is public on Bluesky.`)}
+          to="https://blueskyweb.zendesk.com/hc/en-us/articles/15835264007693-Data-Privacy">
          <Trans>Learn more about what is public on Bluesky.</Trans>
        </InlineLinkText>
      </View>
--- a/src/screens/Signup/StepInfo/Policies.tsx
+++ b/src/screens/Signup/StepInfo/Policies.tsx
@ -45,14 +45,20 @@ export const Policies = ({
  const els = []
  if (tos) {
    els.push(
-      <InlineLinkText key="tos" to={tos}>
+      <InlineLinkText
+        label={_(msg`Read the Bluesky Terms of Service`)}
+        key="tos"
+        to={tos}>
        {_(msg`Terms of Service`)}
      </InlineLinkText>,
    )
  }
  if (pp) {
    els.push(
-      <InlineLinkText key="pp" to={pp}>
+      <InlineLinkText
+        label={_(msg`Read the Bluesky Privacy Policy`)}
+        key="pp"
+        to={pp}>
        {_(msg`Privacy Policy`)}
      </InlineLinkText>,
    )
--- a/src/screens/Signup/index.tsx
+++ b/src/screens/Signup/index.tsx
@ -166,6 +166,7 @@ export function Signup({onPressBack}: {onPressBack: () => void}) {
              <Text style={[t.atoms.text, !gtMobile && a.text_md]}>
                <Trans>Having trouble?</Trans>{' '}
                <InlineLinkText
+                  label={_(msg`Contact support`)}
                  to={FEEDBACK_FORM_URL({email: state.email})}
                  style={[!gtMobile && a.text_md]}>
                  <Trans>Contact support</Trans>
--- a/src/view/com/auth/SplashScreen.web.tsx
+++ b/src/view/com/auth/SplashScreen.web.tsx
@ -132,6 +132,7 @@ export const SplashScreen = ({

 function Footer() {
  const t = useTheme()
+  const {_} = useLingui()

  return (
    <View
@ -147,13 +148,19 @@ function Footer() {
        a.flex_1,
        t.atoms.border_contrast_medium,
      ]}>
-      <InlineLinkText to="https://bsky.social">
+      <InlineLinkText
+        label={_(msg`Learn more about Bluesky`)}
+        to="https://bsky.social">
        <Trans>Business</Trans>
      </InlineLinkText>
-      <InlineLinkText to="https://bsky.social/about/blog">
+      <InlineLinkText
+        label={_(msg`Read the Bluesky blog`)}
+        to="https://bsky.social/about/blog">
        <Trans>Blog</Trans>
      </InlineLinkText>
-      <InlineLinkText to="https://bsky.social/about/join">
+      <InlineLinkText
+        label={_(msg`See jobs at Bluesky`)}
+        to="https://bsky.social/about/join">
        <Trans>Jobs</Trans>
      </InlineLinkText>

--- a/src/view/com/home/HomeHeaderLayoutMobile.tsx
+++ b/src/view/com/home/HomeHeaderLayoutMobile.tsx
@ -73,7 +73,7 @@ export function HomeHeaderLayoutMobile({
          ]}>
          {IS_DEV && (
            <>
-              <Link to="/sys/debug">
+              <Link label="View storybook" to="/sys/debug">
                <ColorPalette size="md" />
              </Link>
            </>
--- a/src/view/com/posts/FeedShutdownMsg.tsx
+++ b/src/view/com/posts/FeedShutdownMsg.tsx
@ -99,6 +99,7 @@ export function FeedShutdownMsg({feedUri}: {feedUri: string}) {
        <Trans>
          This feed is no longer online. We are showing{' '}
          <InlineLinkText
+            label={_(msg`The Discover feed`)}
            to="/profile/bsky.app/feed/whats-hot"
            style={[a.text_md]}>
            Discover
--- a/src/view/screens/Settings/ExportCarDialog.tsx
+++ b/src/view/screens/Settings/ExportCarDialog.tsx
@ -94,6 +94,7 @@ export function ExportCarDialog({
              This feature is in beta. You can read more about repository
              exports in{' '}
              <InlineLinkText
+                label={_(msg`View blogpost for more details`)}
                to="https://docs.bsky.app/blog/repo-export"
                style={[a.text_sm]}>
                this blogpost
--- a/src/view/screens/Storybook/Links.tsx
+++ b/src/view/screens/Storybook/Links.tsx
@ -13,18 +13,20 @@ export function Links() {
      <H1>Links</H1>

      <View style={[a.gap_md, a.align_start]}>
-        <InlineLinkText to="https://google.com" style={[a.text_lg]}>
+        <InlineLinkText label="foo" to="https://google.com" style={[a.text_lg]}>
          https://google.com
        </InlineLinkText>
-        <InlineLinkText to="https://google.com" style={[a.text_lg]}>
+        <InlineLinkText label="foo" to="https://google.com" style={[a.text_lg]}>
          External with custom children (google.com)
        </InlineLinkText>
        <InlineLinkText
+          label="foo"
          to="https://bsky.social"
          style={[a.text_md, t.atoms.text_contrast_low]}>
          Internal (bsky.social)
        </InlineLinkText>
        <InlineLinkText
+          label="foo"
          to="https://bsky.app/profile/bsky.app"
          style={[a.text_md]}>
          Internal (bsky.app)