zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

remove precacheThreadPostProfiles (#3729)

Browse source 
* remove `precacheThreadPostProfiles`

* add `displayName` to `PreviewableUserAvatar`

* memo

* use `precacheProfile`

* pass `profile` directly to `PreviewableUserAvatar`

* update the `UserAvatar`'s props

* remove feed cache

* one more spot

* rm unused queryClient

* Don't call fn unnecessarily

* Preload for display name too

* try notification item

* add to feeditem

* and finally, precache for post threads

* timestamp

* Fix

* onBeforePress

---------

Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
This commit is contained in:
Hailey 2024-04-26 22:31:07 -07:00 • committed by GitHub
parent ce85375c85
commit 7eb1444f2c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 119 additions and 168 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/view/com/util/Link.tsx
View file

@ -148,6 +148,7 @@ export const TextLink = memo(function TextLink({
dataSet,
title,
onPress,
onBeforePress,
disableMismatchWarning,
navigationAction,
anchorNoUnderline,
@ -165,6 +166,7 @@ export const TextLink = memo(function TextLink({
disableMismatchWarning?: boolean
navigationAction?: 'push' | 'replace' | 'navigate'
anchorNoUnderline?: boolean
onBeforePress?: () => void
} & TextProps) {
const {...props} = useLinkProps({to: sanitizeUrl(href)})
const navigation = useNavigationDeduped()
@ -202,6 +204,7 @@ export const TextLink = memo(function TextLink({
// Let the browser handle opening in new tab etc.
return
}
onBeforePress?.()
if (onPress) {
e?.preventDefault?.()
// @ts-ignore function signature differs by platform -prf
@ -226,6 +229,7 @@ export const TextLink = memo(function TextLink({
disableMismatchWarning,
navigationAction,
openLink,
onBeforePress,
],
)
const hrefAttrs = useMemo(() => {
@ -274,6 +278,7 @@ interface TextLinkOnWebOnlyProps extends TextProps {
title?: string
navigationAction?: 'push' | 'replace' | 'navigate'
disableMismatchWarning?: boolean
onBeforePress?: () => void
onPointerEnter?: () => void
anchorNoUnderline?: boolean
}
@ -287,6 +292,7 @@ export const TextLinkOnWebOnly = memo(function DesktopWebTextLink({
lineHeight,
navigationAction,
disableMismatchWarning,
onBeforePress,
...props
}: TextLinkOnWebOnlyProps) {
if (isWeb) {
@ -302,6 +308,7 @@ export const TextLinkOnWebOnly = memo(function DesktopWebTextLink({
title={props.title}
navigationAction={navigationAction}
disableMismatchWarning={disableMismatchWarning}
onBeforePress={onBeforePress}
{...props}
/>
)