zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Hide/show header and footer without re-renders, take two (#1849)

Browse source 
* Remove callsites using the state value

* Remove unused code

* Change shell mode without re-renders

* Adjust "write your reply" for mode
This commit is contained in:
dan 2023-11-09 00:25:27 +00:00 • committed by GitHub
parent bd531f2344
commit 82059b7ee1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 63 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/view/shell/bottom-bar/BottomBar.tsx
View file

@ -39,7 +39,7 @@ export const BottomBar = observer(function BottomBarImpl({
const {isAtHome, isAtSearch, isAtFeeds, isAtNotifications, isAtMyProfile} =
useNavigationTabState()
const {minimalShellMode, footerMinimalShellTransform} = useMinimalShellMode()
const {footerMinimalShellTransform} = useMinimalShellMode()
const {notifications} = store.me
const onPressTab = React.useCallback(
@ -85,7 +85,6 @@ export const BottomBar = observer(function BottomBarImpl({
pal.border,
{paddingBottom: clamp(safeAreaInsets.bottom, 15, 30)},
footerMinimalShellTransform,
minimalShellMode && styles.disabled,
]}>
<Btn
testID="bottomBarHomeBtn"