zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Go back to content-driven slice keys in feeds (#2190)

Browse source 
* Go back to deterministic react keys

* Quick fix to cases when custom feeds serve empty responses
This commit is contained in:
Paul Frazee 2023-12-12 13:07:09 -08:00 • committed by GitHub
parent 90647fe7cf
commit 870505cbe2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/lib/api/feed-manip.ts
View file

@ -14,9 +14,15 @@ export type FeedTunerFn = (
) => FeedViewPostsSlice[]
export class FeedViewPostsSlice {
_reactKey: string
isFlattenedReply = false
constructor(public items: FeedViewPost[], public _reactKey: string) {}
constructor(public items: FeedViewPost[]) {
const item = items[0]
this._reactKey = `slice-${item.post.uri}-${
item.reason?.indexedAt || item.post.indexedAt
}`
}
get uri() {
if (this.isFlattenedReply) {
@ -120,9 +126,7 @@ export class NoopFeedTuner {
feed: FeedViewPost[],
_opts?: {dryRun: boolean; maintainOrder: boolean},
): FeedViewPostsSlice[] {
return feed.map(
item => new FeedViewPostsSlice([item], `slice-${this.keyCounter++}`),
)
return feed.map(item => new FeedViewPostsSlice([item]))
}
}
@ -160,9 +164,7 @@ export class FeedTuner {
})
if (maintainOrder) {
slices = feed.map(
item => new FeedViewPostsSlice([item], `slice-${this.keyCounter++}`),
)
slices = feed.map(item => new FeedViewPostsSlice([item]))
} else {
// arrange the posts into thread slices
for (let i = feed.length - 1; i >= 0; i--) {
@ -178,9 +180,7 @@ export class FeedTuner {
continue
}
}
slices.unshift(
new FeedViewPostsSlice([item], `slice-${this.keyCounter++}`),
)
slices.unshift(new FeedViewPostsSlice([item]))
}
}