zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Add patch for RCTBaseTextInput fixing selectTextOnFocus prop (#4533)

Browse source 
* create patch

* remove js fix in `SearchScreen`
This commit is contained in:
Hailey 2024-06-17 00:56:02 -07:00 • committed by GitHub
parent 10c6035f31
commit 89be5a442c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 44 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/view/screens/Search/Search.tsx
View file

@ -30,7 +30,7 @@ import {makeProfileLink} from '#/lib/routes/links'
import {NavigationProp} from '#/lib/routes/types'
import {augmentSearchQuery} from '#/lib/strings/helpers'
import {logger} from '#/logger'
import {isIOS, isNative, isWeb} from '#/platform/detection'
import {isNative, isWeb} from '#/platform/detection'
import {listenSoftReset} from '#/state/events'
import {useModerationOpts} from '#/state/preferences/moderation-opts'
import {useActorAutocompleteQuery} from '#/state/queries/actor-autocomplete'
@ -802,12 +802,6 @@ let SearchInputBox = ({
})
} else {
setShowAutocomplete(true)
if (isIOS) {
// We rely on selectTextOnFocus, but it's broken on iOS:
// https://github.com/facebook/react-native/issues/41988
textInput.current?.setSelection(0, searchText.length)
// We still rely on selectTextOnFocus for it to be instant on Android.
}
}
}}
onChangeText={onChangeText}