zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Revert "Fix 1338 mark notifications read with timeout and on app state change (#1340)" (#1433) 

This reverts commit d2e65d2a7f.
zio/stable
Paul Frazee 2023-09-11 14:28:13 -07:00 committed by GitHub
parent 57c10cbcab
commit 977f9228f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/view/screens/Notifications.tsx
View File

@ -1,5 +1,5 @@
import React from 'react' import React from 'react'
import {AppState, FlatList, View} from 'react-native' import {FlatList, View} from 'react-native'
import {useFocusEffect} from '@react-navigation/native' import {useFocusEffect} from '@react-navigation/native'
import {observer} from 'mobx-react-lite' import {observer} from 'mobx-react-lite'
import { import {
@ -18,7 +18,6 @@ import {s} from 'lib/styles'
import {useAnalytics} from 'lib/analytics/analytics' import {useAnalytics} from 'lib/analytics/analytics'
import {isWeb} from 'platform/detection' import {isWeb} from 'platform/detection'
const NOTIFICATION_MARK_READ_TIMEOUT = 5000
type Props = NativeStackScreenProps< type Props = NativeStackScreenProps<
NotificationsTabNavigatorParams, NotificationsTabNavigatorParams,
'Notifications' 'Notifications'
@ -56,22 +55,10 @@ export const NotificationsScreen = withAuthRequired(
const softResetSub = store.onScreenSoftReset(onPressLoadLatest) const softResetSub = store.onScreenSoftReset(onPressLoadLatest)
store.me.notifications.update() store.me.notifications.update()
screen('Notifications') screen('Notifications')
// marks notifications read if the user opens the notifications tab for x seconds
// but doesn't open any notifications or any other tab
const markReadTimeout = setTimeout(() => {
store.me.notifications.markAllRead()
}, NOTIFICATION_MARK_READ_TIMEOUT) // mark all notifications as read after 3s
// marks notification read if the user suspends the app while in the notification tab
// then opens the app into the notification tab and then closes the app again
const markReadOnBlur = AppState.addEventListener('change', event => {
if (event === 'background') store.me.notifications.markAllRead()
})
return () => { return () => {
softResetSub.remove() softResetSub.remove()
markReadOnBlur.remove()
store.me.notifications.markAllRead() store.me.notifications.markAllRead()
clearTimeout(markReadTimeout) // in case we unmount before the timeout fires
} }
}, [store, screen, onPressLoadLatest]), }, [store, screen, onPressLoadLatest]),
) )