Ensure `/start` navigates to `/starter-pack` when clicking a link internally (#4745)

* remove temporary metadata removal

* ensure proper navigation

src/lib/strings/url-helpers.ts

@@ -5,6 +5,7 @@ import TLDs from 'tlds'
 import {logger} from '#/logger'
 import {BSKY_SERVICE} from 'lib/constants'
 import {isInvalidHandle} from 'lib/strings/handles'
+import {startUriToStarterPackUri} from 'lib/strings/starter-pack'
 
 export const BSKY_APP_HOST = 'https://bsky.app'
 const BSKY_TRUSTED_HOSTS = [
@@ -187,6 +188,11 @@ export function convertBskyAppUrlIfNeeded(url: string): string {
   if (isBskyAppUrl(url)) {
     try {
       const urlp = new URL(url)
+
+      if (isBskyStartUrl(url)) {
+        return startUriToStarterPackUri(urlp.pathname)
+      }
+
       return urlp.pathname
     } catch (e) {
       console.error('Unexpected error in convertBskyAppUrlIfNeeded()', e)

src/view/com/util/post-embeds/ExternalLinkEmbed.tsx

@@ -79,7 +79,6 @@ export const ExternalLinkEmbed = ({
         ) : embedPlayerParams ? (
           <ExternalPlayer link={link} params={embedPlayerParams} />
         ) : undefined}
-        {!starterPackParsed ? (
         <View
           style={[
             a.flex_1,
@@ -109,7 +108,6 @@ export const ExternalLinkEmbed = ({
             </Text>
           ) : undefined}
         </View>
-        ) : null}
       </LinkWrapper>
     </View>
   )