zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Use non-reactive callbacks for some methods (#1948)

Browse source 
* Use non-reactive callbacks for some methods

* Remove unnecessary state

* Use non-reactive callbacks for modals
This commit is contained in:
dan 2023-11-17 06:18:37 +00:00 • committed by GitHub
parent a10adf8908
commit a8aed2c38e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 34 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/state/lightbox.tsx
View file

@ -1,5 +1,6 @@
import React from 'react'
import {AppBskyActorDefs} from '@atproto/api'
import {useNonReactiveCallback} from '#/lib/hooks/useNonReactiveCallback'
interface Lightbox {
name: string
@ -42,18 +43,15 @@ export function Provider({children}: React.PropsWithChildren<{}>) {
null,
)
const openLightbox = React.useCallback(
(lightbox: Lightbox) => {
setActiveLightbox(lightbox)
},
[setActiveLightbox],
)
const openLightbox = useNonReactiveCallback((lightbox: Lightbox) => {
setActiveLightbox(lightbox)
})
const closeLightbox = React.useCallback(() => {
const closeLightbox = useNonReactiveCallback(() => {
let wasActive = !!activeLightbox
setActiveLightbox(null)
return wasActive
}, [setActiveLightbox, activeLightbox])
})
const state = React.useMemo(
() => ({