zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

add types for `desktopFixedHeight` to `List` (#4356) 

* add types for `desktopFixedHeight`

* nit

* accept both `number` and `boolean`
zio/stable
Hailey 2024-06-05 09:03:40 -07:00 committed by GitHub
parent 22858192dc
commit af2aaa1f39
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/view/com/util/List.tsx
View File

@ -25,6 +25,7 @@ export type ListProps<ItemT> = Omit<
onRefresh?: () => void onRefresh?: () => void
onItemSeen?: (item: ItemT) => void onItemSeen?: (item: ItemT) => void
containWeb?: boolean containWeb?: boolean
desktopFixedHeight?: number | boolean
sideBorders?: boolean sideBorders?: boolean
// Web only prop to disable a perf optimization (which would otherwise be on). // Web only prop to disable a perf optimization (which would otherwise be on).
disableContentVisibility?: boolean disableContentVisibility?: boolean

2
src/view/com/util/List.web.tsx
View File

@ -22,7 +22,7 @@ export type ListProps<ItemT> = Omit<
refreshing?: boolean refreshing?: boolean
onRefresh?: () => void onRefresh?: () => void
onItemSeen?: (item: ItemT) => void onItemSeen?: (item: ItemT) => void
desktopFixedHeight: any // TODO: Better types. desktopFixedHeight?: number | boolean
containWeb?: boolean containWeb?: boolean
sideBorders?: boolean sideBorders?: boolean
disableContentVisibility?: boolean disableContentVisibility?: boolean