zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Fix a couple incorrect link detections ('e.g.' and 'foo.jpg') (close #13)

Browse source
This commit is contained in:
Paul Frazee 2022-11-28 10:22:08 -06:00
parent 8723b51693
commit bcb1ad98de
4 changed files with 51 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

22
__tests__/string-utils.ts
View file

@ -31,6 +31,11 @@ describe('extractEntities', () => {
'start middle end.com/foo/bar?baz=bux#hash',
'newline1.com\nnewline2.com',
'not.. a..url ..here',
'e.g.',
'something-cool.jpg',
'website.com.jpg',
'e.g./foo',
'website.com.jpg/foo',
]
interface Output {
type: string
@ -80,6 +85,11 @@ describe('extractEntities', () => {
{type: 'link', value: 'newline2.com', noScheme: true},
],
[],
[],
[],
[],
[],
[],
]
it('correctly handles a set of text inputs', () => {
for (let i = 0; i < inputs.length; i++) {
@ -145,6 +155,12 @@ describe('detectLinkables', () => {
'start middle end.com/foo/bar?baz=bux#hash',
'newline1.com\nnewline2.com',
'not.. a..url ..here',
'e.g.',
'e.g. real.com fake.notreal',
'something-cool.jpg',
'website.com.jpg',
'e.g./foo',
'website.com.jpg/foo',
]
const outputs = [
['no linkable'],
@ -171,6 +187,12 @@ describe('detectLinkables', () => {
['start middle ', {link: 'end.com/foo/bar?baz=bux#hash'}],
[{link: 'newline1.com'}, '\n', {link: 'newline2.com'}],
['not.. a..url ..here'],
['e.g.'],
['e.g. ', {link: 'real.com'}, ' fake.notreal'],
['something-cool.jpg'],
['website.com.jpg'],
['e.g./foo'],
['website.com.jpg/foo'],
]
it('correctly handles a set of text inputs', () => {
for (let i = 0; i < inputs.length; i++) {