zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Better handling of blocks in `KnownFollowers` (#4563) 

* Better handle nested conditionals, use renderable items to determine UI

* Better translate

* Fix translation and fix missing case in the process

* Clarify naming

* Add safeguard

* Remove unneeded msg

---------

Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
zio/stable
Eric Bailey 2024-06-18 17:33:17 -05:00 committed by GitHub
parent 32b4063185
commit c92ef2fe31
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 49 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/components/KnownFollowers.tsx
View File

@ -100,7 +100,15 @@ function KnownFollowersInner({
moderation,
}
})
const count = cachedKnownFollowers.count
// Does not have blocks applied. Always >= slices.length
const serverCount = cachedKnownFollowers.count
/*
* We check above too, but here for clarity and a reminder to _check for
* valid indices_
*/
if (slice.length === 0) return null
return (
<Link
@ -164,7 +172,9 @@ function KnownFollowersInner({
},
]}
numberOfLines={2}>
{count > 2 ? (
{slice.length >= 2 ? (
// 2-n followers, including blocks
serverCount > 2 ? (
<Trans>
Followed by{' '}
<Text key={slice[0].profile.did} style={textStyle}>
@ -175,9 +185,14 @@ function KnownFollowersInner({
{slice[1].profile.displayName}
</Text>
, and{' '}
<Plural value={count - 2} one="# other" other="# others" />
<Plural
value={serverCount - 2}
one="# other"
other="# others"
/>
</Trans>
) : count === 2 ? (
) : (
// only 2
<Trans>
Followed by{' '}
<Text key={slice[0].profile.did} style={textStyle}>
@ -188,7 +203,23 @@ function KnownFollowersInner({
{slice[1].profile.displayName}
</Text>
</Trans>
)
) : serverCount > 1 ? (
// 1-n followers, including blocks
<Trans>
Followed by{' '}
<Text key={slice[0].profile.did} style={textStyle}>
{slice[0].profile.displayName}
</Text>{' '}
and{' '}
<Plural
value={serverCount - 1}
one="# other"
other="# others"
/>
</Trans>
) : (
// only 1
<Trans>
Followed by{' '}
<Text key={slice[0].profile.did} style={textStyle}>