zio
/
bsky-app
2
0
Fork 0
Code Pull Requests Packages Releases Activity

Remove unnecessary opacity logic (#1646)

zio/stable
dan 2023-10-09 22:29:56 +01:00 committed by GitHub
parent b12cfbe90b
commit ce0f796008
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/view/com/lightbox/ImageViewing/index.tsx
View File

@ -71,7 +71,6 @@ function ImageViewing({
const imageList = useRef<VirtualizedList<ImageSource>>(null) const imageList = useRef<VirtualizedList<ImageSource>>(null)
const [isScaled, setIsScaled] = useState(false) const [isScaled, setIsScaled] = useState(false)
const [isDragging, setIsDragging] = useState(false) const [isDragging, setIsDragging] = useState(false)
const [opacity, setOpacity] = useState(1)
const [currentImageIndex, setImageIndex] = useState(imageIndex) const [currentImageIndex, setImageIndex] = useState(imageIndex)
const [headerTranslate] = useState( const [headerTranslate] = useState(
() => new Animated.ValueXY(INITIAL_POSITION), () => new Animated.ValueXY(INITIAL_POSITION),
@ -100,12 +99,6 @@ function ImageViewing({
} }
} }
const onRequestCloseEnhanced = () => {
setOpacity(0)
onRequestClose()
setTimeout(() => setOpacity(1), 0)
}
const onScroll = (event: NativeSyntheticEvent<NativeScrollEvent>) => { const onScroll = (event: NativeSyntheticEvent<NativeScrollEvent>) => {
const { const {
nativeEvent: { nativeEvent: {
@ -162,14 +155,14 @@ function ImageViewing({
aria-modal aria-modal
accessibilityViewIsModal> accessibilityViewIsModal>
<ModalsContainer /> <ModalsContainer />
<View style={[styles.container, {opacity, backgroundColor}]}> <View style={[styles.container, {backgroundColor}]}>
<Animated.View style={[styles.header, {transform: headerTransform}]}> <Animated.View style={[styles.header, {transform: headerTransform}]}>
{typeof HeaderComponent !== 'undefined' ? ( {typeof HeaderComponent !== 'undefined' ? (
React.createElement(HeaderComponent, { React.createElement(HeaderComponent, {
imageIndex: currentImageIndex, imageIndex: currentImageIndex,
}) })
) : ( ) : (
<ImageDefaultHeader onRequestClose={onRequestCloseEnhanced} /> <ImageDefaultHeader onRequestClose={onRequestClose} />
)} )}
</Animated.View> </Animated.View>
<VirtualizedList <VirtualizedList
@ -191,7 +184,7 @@ function ImageViewing({
<ImageItem <ImageItem
onZoom={onZoom} onZoom={onZoom}
imageSrc={imageSrc} imageSrc={imageSrc}
onRequestClose={onRequestCloseEnhanced} onRequestClose={onRequestClose}
pinchGestureRef={pinchGestureRefs.get(imageSrc)} pinchGestureRef={pinchGestureRefs.get(imageSrc)}
isScrollViewBeingDragged={isDragging} isScrollViewBeingDragged={isDragging}
/> />