Mark `under13` and `Next` and `Back` buttons in signup for localisation (#3341)

* Mark under13 string for translation

* Mark buttons for localisation

* tweak label

* wrap in `ButtonText`

* lint

* try to fix lint again
zio/stable
surfdude29 2024-03-22 17:18:00 +00:00 committed by GitHub
parent 5b44aa962f
commit d507fa9f38
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 7 deletions

View File

@ -76,7 +76,7 @@ export const Policies = ({
{under13 ? ( {under13 ? (
<Text style={[a.font_bold, a.leading_snug, t.atoms.text_contrast_high]}> <Text style={[a.font_bold, a.leading_snug, t.atoms.text_contrast_high]}>
You must be 13 years of age or older to sign up. <Trans>You must be 13 years of age or older to sign up.</Trans>
</Text> </Text>
) : needsGuardian ? ( ) : needsGuardian ? (
<Text style={[a.font_bold, a.leading_snug, t.atoms.text_contrast_high]}> <Text style={[a.font_bold, a.leading_snug, t.atoms.text_contrast_high]}>

View File

@ -170,34 +170,40 @@ export function Signup({onPressBack}: {onPressBack: () => void}) {
<View style={[a.flex_row, a.justify_between, a.pb_lg]}> <View style={[a.flex_row, a.justify_between, a.pb_lg]}>
<Button <Button
label="Back" label={_(msg`Go back to previous step`)}
variant="solid" variant="solid"
color="secondary" color="secondary"
size="medium" size="medium"
onPress={onBackPress}> onPress={onBackPress}>
Back <ButtonText>
<Trans>Back</Trans>
</ButtonText>
</Button> </Button>
{state.activeStep !== SignupStep.CAPTCHA && ( {state.activeStep !== SignupStep.CAPTCHA && (
<> <>
{isError ? ( {isError ? (
<Button <Button
label="Retry" label={_(msg`Press to retry`)}
variant="solid" variant="solid"
color="primary" color="primary"
size="medium" size="medium"
disabled={state.isLoading} disabled={state.isLoading}
onPress={() => refetch()}> onPress={() => refetch()}>
Retry <ButtonText>
<Trans>Retry</Trans>
</ButtonText>
</Button> </Button>
) : ( ) : (
<Button <Button
label="Next" label={_(msg`Continue to next step`)}
variant="solid" variant="solid"
color="primary" color="primary"
size="medium" size="medium"
disabled={!state.canNext || state.isLoading} disabled={!state.canNext || state.isLoading}
onPress={onNextPress}> onPress={onNextPress}>
<ButtonText>Next</ButtonText> <ButtonText>
<Trans>Next</Trans>
</ButtonText>
</Button> </Button>
)} )}
</> </>