zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Improve image cropping on android and introduce aspect ratio field (#1525)

Browse source 
* Fix image cropping on android

* Store and use aspect ratio field in post images (close #1392)
This commit is contained in:
Paul Frazee 2023-09-27 09:08:21 -07:00 • committed by GitHub
parent 6325eff938
commit d87c232660
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/state/models/media/image.ts
View file

@ -8,6 +8,7 @@ import {openCropper} from 'lib/media/picker'
import {ActionCrop, FlipType, SaveFormat} from 'expo-image-manipulator'
import {Position} from 'react-avatar-editor'
import {Dimensions} from 'lib/media/types'
import {isIOS} from 'platform/detection'
export interface ImageManipulationAttributes {
aspectRatio?: '4:3' | '1:1' | '3:4' | 'None'
@ -164,8 +165,13 @@ export class ImageModel implements Omit<RNImage, 'size'> {
// Mobile
async crop() {
try {
// openCropper requires an output width and height hence
// getting upload dimensions before cropping is necessary.
// NOTE
// on ios, react-native-image-cropper gives really bad quality
// without specifying width and height. on android, however, the
// crop stretches incorrectly if you do specify it. these are
// both separate bugs in the library. we deal with that by
// providing width & height for ios only
// -prf
const {width, height} = this.getUploadDimensions({
width: this.width,
height: this.height,
@ -175,8 +181,7 @@ export class ImageModel implements Omit<RNImage, 'size'> {
mediaType: 'photo',
path: this.path,
freeStyleCropEnabled: true,
width,
height,
...(isIOS ? {width, height} : {}),
})
runInAction(() => {