Fix notification scroll jump (#5297)
parent
4d22adbcf6
commit
e0d9e75407
|
@ -175,9 +175,19 @@ async function fetchSubjects(
|
||||||
}> {
|
}> {
|
||||||
const postUris = new Set<string>()
|
const postUris = new Set<string>()
|
||||||
const packUris = new Set<string>()
|
const packUris = new Set<string>()
|
||||||
|
|
||||||
|
const postUrisWithLikes = new Set<string>()
|
||||||
|
const postUrisWithReposts = new Set<string>()
|
||||||
|
|
||||||
for (const notif of groupedNotifs) {
|
for (const notif of groupedNotifs) {
|
||||||
if (notif.subjectUri?.includes('app.bsky.feed.post')) {
|
if (notif.subjectUri?.includes('app.bsky.feed.post')) {
|
||||||
postUris.add(notif.subjectUri)
|
postUris.add(notif.subjectUri)
|
||||||
|
if (notif.type === 'post-like') {
|
||||||
|
postUrisWithLikes.add(notif.subjectUri)
|
||||||
|
}
|
||||||
|
if (notif.type === 'repost') {
|
||||||
|
postUrisWithReposts.add(notif.subjectUri)
|
||||||
|
}
|
||||||
} else if (
|
} else if (
|
||||||
notif.notification.reasonSubject?.includes('app.bsky.graph.starterpack')
|
notif.notification.reasonSubject?.includes('app.bsky.graph.starterpack')
|
||||||
) {
|
) {
|
||||||
|
@ -206,6 +216,15 @@ async function fetchSubjects(
|
||||||
AppBskyFeedPost.validateRecord(post.record).success
|
AppBskyFeedPost.validateRecord(post.record).success
|
||||||
) {
|
) {
|
||||||
postsMap.set(post.uri, post)
|
postsMap.set(post.uri, post)
|
||||||
|
|
||||||
|
// HACK. In some cases, the appview appears to lag behind and returns empty counters.
|
||||||
|
// To prevent scroll jump due to missing metrics, fill in 1 like/repost instead of 0.
|
||||||
|
if (post.likeCount === 0 && postUrisWithLikes.has(post.uri)) {
|
||||||
|
post.likeCount = 1
|
||||||
|
}
|
||||||
|
if (post.repostCount === 0 && postUrisWithReposts.has(post.uri)) {
|
||||||
|
post.repostCount = 1
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
for (const pack of packsChunks.flat()) {
|
for (const pack of packsChunks.flat()) {
|
||||||
|
|
Loading…
Reference in New Issue