zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Cleanup gates (#4170)

Browse source 
* Unlaunch disable_poll_on_discover_v2

* Rm unused gates

* Unlaunch autoexpand_suggestions_on_profile_follow_v2

* Launch disable_min_shell_on_foregrounding_v3
This commit is contained in:
dan 2024-05-22 18:19:07 +01:00 • committed by GitHub
parent 3ca41e4efb
commit e6e7027d01
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 9 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/view/screens/Home.tsx
View file

@ -6,7 +6,7 @@ import {PROD_DEFAULT_FEED} from '#/lib/constants'
import {useNonReactiveCallback} from '#/lib/hooks/useNonReactiveCallback'
import {useSetTitle} from '#/lib/hooks/useSetTitle'
import {useWebMediaQueries} from '#/lib/hooks/useWebMediaQueries'
import {logEvent, LogEvents, useGate} from '#/lib/statsig/statsig'
import {logEvent, LogEvents} from '#/lib/statsig/statsig'
import {emitSoftReset} from '#/state/events'
import {SavedFeedSourceInfo, usePinnedFeedsInfos} from '#/state/queries/feed'
import {FeedParams} from '#/state/queries/post-feed'
@ -59,7 +59,6 @@ function HomeScreenReady({
preferences: UsePreferencesQueryResponse
pinnedFeedInfos: SavedFeedSourceInfo[]
}) {
const gate = useGate()
const requestNotificationsPermission = useRequestNotificationsPermission()
const allFeeds = React.useMemo(
@ -123,11 +122,9 @@ function HomeScreenReady({
React.useCallback(() => {
const listener = AppState.addEventListener('change', nextAppState => {
if (nextAppState === 'active') {
if (
isMobile &&
mode.value === 1 &&
gate('disable_min_shell_on_foregrounding_v3')
) {
if (isMobile && mode.value === 1) {
// Reveal the bottom bar so you don't miss notifications or messages.
// TODO: Experiment with only doing it when unread > 0.
setMinimalShellMode(false)
}
}
@ -135,7 +132,7 @@ function HomeScreenReady({
return () => {
listener.remove()
}
}, [setMinimalShellMode, mode, isMobile, gate]),
}, [setMinimalShellMode, mode, isMobile]),
)
const onPageSelected = React.useCallback(