zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Show just-posted replies above OP replies (#4901)

Browse source 
* Unify onPostReply handler

* Show just-posted replies above OP replies

* Only do this for the highlighted post or thread mode

It's confusing to have your post displace OP thread or other people's leaf posts.
This commit is contained in:
dan 2024-08-08 19:19:58 +01:00 • committed by GitHub
parent c1af767fa6
commit e782db33dc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 53 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/state/queries/post-thread.ts
View file

@ -137,6 +137,7 @@ export function sortThread(
opts: UsePreferencesQueryResponse['threadViewPrefs'],
modCache: ThreadModerationCache,
currentDid: string | undefined,
justPostedUris: Set<string>,
): ThreadNode {
if (node.type !== 'post') {
return node
@ -150,6 +151,20 @@ export function sortThread(
return -1
}
if (node.ctx.isHighlightedPost || opts.lab_treeViewEnabled) {
const aIsJustPosted =
a.post.author.did === currentDid && justPostedUris.has(a.post.uri)
const bIsJustPosted =
b.post.author.did === currentDid && justPostedUris.has(b.post.uri)
if (aIsJustPosted && bIsJustPosted) {
return a.post.indexedAt.localeCompare(b.post.indexedAt) // oldest
} else if (aIsJustPosted) {
return -1 // reply while onscreen
} else if (bIsJustPosted) {
return 1 // reply while onscreen
}
}
const aIsByOp = a.post.author.did === node.post?.author.did
const bIsByOp = b.post.author.did === node.post?.author.did
if (aIsByOp && bIsByOp) {
@ -206,7 +221,9 @@ export function sortThread(
}
return b.post.indexedAt.localeCompare(a.post.indexedAt)
})
node.replies.forEach(reply => sortThread(reply, opts, modCache, currentDid))
node.replies.forEach(reply =>
sortThread(reply, opts, modCache, currentDid, justPostedUris),
)
}
return node
}