zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Resolve all remaining lint issues (#88)

Browse source 
* Rework 'navIdx' variables from number arrays to strings to avoid equality-check failures in react hooks

* Resolve all remaining lint issues

* Fix tests

* Use node v18 in gh action test
This commit is contained in:
Paul Frazee 2023-01-24 13:00:11 -06:00 • committed by GitHub
parent 3a90114f3a
commit f36c956536
60 changed files with 478 additions and 482 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/view/com/post/Post.tsx
View file

@ -156,7 +156,7 @@ export const Post = observer(function Post({
timestamp={item.post.indexedAt}
/>
{replyAuthorDid !== '' && (
<View style={[s.flexRow, s.mb2, {alignItems: 'center'}]}>
<View style={[s.flexRow, s.mb2, s.alignCenter]}>
<FontAwesomeIcon
icon="reply"
size={9}
@ -187,10 +187,8 @@ export const Post = observer(function Post({
lineHeight={1.3}
/>
</View>
) : (
<View style={{height: 5}} />
)}
<PostEmbeds embed={item.post.embed} style={{marginBottom: 10}} />
) : undefined}
<PostEmbeds embed={item.post.embed} style={s.mb10} />
<PostCtrls
itemHref={itemHref}
itemTitle={itemTitle}

12
src/view/com/post/PostText.tsx
View file

@ -1,6 +1,6 @@
import React, {useState, useEffect} from 'react'
import {observer} from 'mobx-react-lite'
import {View} from 'react-native'
import {StyleSheet, View} from 'react-native'
import {LoadingPlaceholder} from '../util/LoadingPlaceholder'
import {ErrorMessage} from '../util/error/ErrorMessage'
import {Text} from '../util/text/Text'
@ -31,9 +31,9 @@ export const PostText = observer(function PostText({
if (!model || model.isLoading || model.uri !== uri) {
return (
<View>
<LoadingPlaceholder width="100%" height={8} style={{marginTop: 6}} />
<LoadingPlaceholder width="100%" height={8} style={{marginTop: 6}} />
<LoadingPlaceholder width={100} height={8} style={{marginTop: 6}} />
<LoadingPlaceholder width="100%" height={8} style={styles.mt6} />
<LoadingPlaceholder width="100%" height={8} style={styles.mt6} />
<LoadingPlaceholder width={100} height={8} style={styles.mt6} />
</View>
)
}
@ -56,3 +56,7 @@ export const PostText = observer(function PostText({
</View>
)
})
const styles = StyleSheet.create({
mt6: {marginTop: 6},
})