Resolve all remaining lint issues (#88)

* Rework 'navIdx' variables from number arrays to strings to avoid equality-check failures in react hooks

* Resolve all remaining lint issues

* Fix tests

* Use node v18 in gh action test
This commit is contained in:
Paul Frazee 2023-01-24 13:00:11 -06:00 committed by GitHub
parent 3a90114f3a
commit f36c956536
60 changed files with 478 additions and 482 deletions

View file

@ -33,7 +33,7 @@ export const Settings = observer(function Settings({
}
store.shell.setMinimalShellMode(false)
store.nav.setTitle(navIdx, 'Settings')
}, [visible, store])
}, [visible, store, navIdx])
const onPressSwitchAccount = async (acct: AccountData) => {
setIsSwitching(true)
@ -130,8 +130,8 @@ export const Settings = observer(function Settings({
style={[
pal.view,
styles.profile,
styles.alignCenter,
s.mb2,
{alignItems: 'center'},
isSwitching && styles.dimmed,
]}
onPress={isSwitching ? undefined : onPressAddAccount}>
@ -142,7 +142,7 @@ export const Settings = observer(function Settings({
</Text>
</View>
</TouchableOpacity>
<View style={{height: 50}} />
<View style={styles.spacer} />
<Text type="sm-medium" style={[s.mb5]}>
Developer tools
</Text>
@ -168,6 +168,12 @@ const styles = StyleSheet.create({
dimmed: {
opacity: 0.5,
},
spacer: {
height: 50,
},
alignCenter: {
alignItems: 'center',
},
title: {
fontSize: 32,
fontWeight: 'bold',