Resolve all remaining lint issues (#88)

* Rework 'navIdx' variables from number arrays to strings to avoid equality-check failures in react hooks

* Resolve all remaining lint issues

* Fix tests

* Use node v18 in gh action test
This commit is contained in:
Paul Frazee 2023-01-24 13:00:11 -06:00 committed by GitHub
parent 3a90114f3a
commit f36c956536
60 changed files with 478 additions and 482 deletions

View file

@ -32,7 +32,7 @@ import {Text} from '../../com/util/text/Text'
import {ErrorBoundary} from '../../com/util/ErrorBoundary'
import {TabsSelector} from './TabsSelector'
import {Composer} from './Composer'
import {colors} from '../../lib/styles'
import {s, colors} from '../../lib/styles'
import {clamp} from '../../../lib/numbers'
import {
GridIcon,
@ -385,7 +385,7 @@ export const MobileShell: React.FC = observer(() => {
/>
<Animated.View
style={[
{height: '100%'},
s.h100pct,
screenBg,
current
? [
@ -486,7 +486,7 @@ export const MobileShell: React.FC = observer(() => {
*/
type ScreenRenderDesc = MatchResult & {
key: string
navIdx: [number, number]
navIdx: string
current: boolean
previous: boolean
isNewTab: boolean
@ -514,7 +514,7 @@ function constructScreenRenderDesc(nav: NavigationModel): {
hasNewTab = hasNewTab || tab.isNewTab
return Object.assign(matchRes, {
key: `t${tab.id}-s${screen.index}`,
navIdx: [tab.id, screen.id],
navIdx: `${tab.id}-${screen.id}`,
current: isCurrent,
previous: isPrevious,
isNewTab: tab.isNewTab,