Implement logging system

This commit is contained in:
Paul Frazee 2023-01-02 17:38:13 -06:00
parent 99cec71ed7
commit f6a0e634d7
39 changed files with 442 additions and 125 deletions

View file

@ -1,7 +1,6 @@
import React, {useCallback} from 'react'
import {Image, StyleSheet, TouchableOpacity, ScrollView} from 'react-native'
import {FontAwesomeIcon} from '@fortawesome/react-native-fontawesome'
import {colors} from '../../lib/styles'
import {
openPicker,
openCamera,
@ -9,6 +8,7 @@ import {
} from 'react-native-image-crop-picker'
import {compressIfNeeded} from '../../../lib/images'
import {usePalette} from '../../lib/hooks/usePalette'
import {useStores} from '../../../state'
const IMAGE_PARAMS = {
width: 1000,
@ -28,6 +28,7 @@ export const PhotoCarouselPicker = ({
localPhotos: any
}) => {
const pal = usePalette('default')
const store = useStores()
const handleOpenCamera = useCallback(async () => {
try {
const cameraRes = await openCamera({
@ -37,11 +38,11 @@ export const PhotoCarouselPicker = ({
})
const uri = await compressIfNeeded(cameraRes, 300000)
onSelectPhotos([uri, ...selectedPhotos])
} catch (err) {
} catch (err: any) {
// ignore
console.log('Error using camera', err)
store.log.warn('Error using camera', err.toString())
}
}, [selectedPhotos, onSelectPhotos])
}, [store.log, selectedPhotos, onSelectPhotos])
const handleSelectPhoto = useCallback(
async (uri: string) => {
@ -53,12 +54,12 @@ export const PhotoCarouselPicker = ({
})
const finalUri = await compressIfNeeded(cropperRes, 300000)
onSelectPhotos([finalUri, ...selectedPhotos])
} catch (err) {
} catch (err: any) {
// ignore
console.log('Error selecting photo', err)
store.log.warn('Error selecting photo', err.toString())
}
},
[selectedPhotos, onSelectPhotos],
[store.log, selectedPhotos, onSelectPhotos],
)
const handleOpenGallery = useCallback(() => {

View file

@ -42,11 +42,12 @@ export const SuggestedFollows = observer(
)
useEffect(() => {
console.log('Fetching suggested actors')
view
.setup()
.catch((err: any) => console.error('Failed to fetch suggestions', err))
}, [view])
.catch((err: any) =>
store.log.error('Failed to fetch suggestions', err.toString()),
)
}, [view, store.log])
useEffect(() => {
if (!view.isLoading && !view.hasError && !view.hasContent) {
@ -57,14 +58,16 @@ export const SuggestedFollows = observer(
const onPressTryAgain = () =>
view
.setup()
.catch((err: any) => console.error('Failed to fetch suggestions', err))
.catch((err: any) =>
store.log.error('Failed to fetch suggestions', err.toString()),
)
const onPressFollow = async (item: SuggestedActor) => {
try {
const res = await apilib.follow(store, item.did, item.declaration.cid)
setFollows({[item.did]: res.uri, ...follows})
} catch (e) {
console.log(e)
} catch (e: any) {
store.log.error('Failed fo create follow', {error: e.toString(), item})
Toast.show('An issue occurred, please try again.')
}
}
@ -72,8 +75,8 @@ export const SuggestedFollows = observer(
try {
await apilib.unfollow(store, follows[item.did])
setFollows(_omit(follows, [item.did]))
} catch (e) {
console.log(e)
} catch (e: any) {
store.log.error('Failed fo delete follow', {error: e.toString(), item})
Toast.show('An issue occurred, please try again.')
}
}

View file

@ -44,7 +44,6 @@ export const CreateAccount = ({onPressBack}: {onPressBack: () => void}) => {
let aborted = false
setError('')
setServiceDescription(undefined)
console.log('Fetching service description', serviceUrl)
store.session.describeService(serviceUrl).then(
desc => {
if (aborted) return
@ -53,7 +52,10 @@ export const CreateAccount = ({onPressBack}: {onPressBack: () => void}) => {
},
err => {
if (aborted) return
console.error(err)
store.log.warn(
`Failed to fetch service description for ${serviceUrl}`,
err.toString(),
)
setError(
'Unable to contact your service. Please check your Internet connection.',
)
@ -62,7 +64,7 @@ export const CreateAccount = ({onPressBack}: {onPressBack: () => void}) => {
return () => {
aborted = true
}
}, [serviceUrl, store.session])
}, [serviceUrl, store.session, store.log])
const onPressSelectService = () => {
store.shell.openModal(new ServerInputModal(serviceUrl, setServiceUrl))
@ -98,7 +100,7 @@ export const CreateAccount = ({onPressBack}: {onPressBack: () => void}) => {
errMsg =
'Invite code not accepted. Check that you input it correctly and try again.'
}
console.log(e)
store.log.warn('Failed to create account', e.toString())
setIsProcessing(false)
setError(errMsg.replace(/^Error:/, ''))
}

View file

@ -44,7 +44,6 @@ export const Signin = ({onPressBack}: {onPressBack: () => void}) => {
useEffect(() => {
let aborted = false
setError('')
console.log('Fetching service description', serviceUrl)
store.session.describeService(serviceUrl).then(
desc => {
if (aborted) return
@ -52,7 +51,10 @@ export const Signin = ({onPressBack}: {onPressBack: () => void}) => {
},
err => {
if (aborted) return
console.error(err)
store.log.warn(
`Failed to fetch service description for ${serviceUrl}`,
err.toString(),
)
setError(
'Unable to contact your service. Please check your Internet connection.',
)
@ -61,7 +63,7 @@ export const Signin = ({onPressBack}: {onPressBack: () => void}) => {
return () => {
aborted = true
}
}, [store.session, serviceUrl])
}, [store.session, store.log, serviceUrl])
return (
<KeyboardAvoidingView behavior="padding" style={{flex: 1}}>
@ -169,7 +171,7 @@ const LoginForm = ({
})
} catch (e: any) {
const errMsg = e.toString()
console.log(e)
store.log.warn('Failed to login', e.toString())
setIsProcessing(false)
if (errMsg.includes('Authentication Required')) {
setError('Invalid username or password')
@ -305,7 +307,7 @@ const ForgotPasswordForm = ({
onEmailSent()
} catch (e: any) {
const errMsg = e.toString()
console.log(e)
store.log.warn('Failed to request password reset', e.toString())
setIsProcessing(false)
if (isNetworkError(e)) {
setError(
@ -417,7 +419,7 @@ const SetNewPasswordForm = ({
onPasswordSet()
} catch (e: any) {
const errMsg = e.toString()
console.log(e)
store.log.warn('Failed to set new password', e.toString())
setIsProcessing(false)
if (isNetworkError(e)) {
setError(

View file

@ -55,7 +55,13 @@ export function Component({}: {}) {
displayName,
description,
})
.catch(e => console.error(e)) // an error here is not critical
.catch(e =>
// an error here is not critical
store.log.error(
'Failed to update scene profile during creation',
e.toString(),
),
)
// follow the scene
await store.api.app.bsky.graph.follow
.create(
@ -70,7 +76,13 @@ export function Component({}: {}) {
createdAt: new Date().toISOString(),
},
)
.catch(e => console.error(e)) // an error here is not critical
.catch(e =>
// an error here is not critical
store.log.error(
'Failed to follow scene after creation',
e.toString(),
),
)
Toast.show('Scene created')
store.shell.closeModal()
store.nav.navigate(`/profile/${fullHandle}`)
@ -82,7 +94,7 @@ export function Component({}: {}) {
} else if (e instanceof AppBskyActorCreateScene.HandleNotAvailableError) {
setError(`The handle "${handle}" is not available.`)
} else {
console.error(e)
store.log.error('Failed to create scene', e.toString())
setError(
'Failed to create the scene. Check your internet connection and try again.',
)

View file

@ -84,9 +84,9 @@ export const Component = observer(function Component({
)
setCreatedInvites({[follow.did]: assertionUri, ...createdInvites})
Toast.show('Invite sent')
} catch (e) {
} catch (e: any) {
setError('There was an issue with the invite. Please try again.')
console.error(e)
store.log.error('Failed to invite user to scene', e.toString())
}
}
const onPressUndo = async (subjectDid: string, assertionUri: string) => {
@ -98,9 +98,9 @@ export const Component = observer(function Component({
rkey: urip.rkey,
})
setCreatedInvites(_omit(createdInvites, [subjectDid]))
} catch (e) {
} catch (e: any) {
setError('There was an issue with the invite. Please try again.')
console.error(e)
store.log.error('Failed to delete a scene invite', e.toString())
}
}
@ -117,9 +117,9 @@ export const Component = observer(function Component({
...deletedPendingInvites,
})
Toast.show('Invite removed')
} catch (e) {
} catch (e: any) {
setError('There was an issue with the invite. Please try again.')
console.error(e)
store.log.error('Failed to delete an invite', e.toString())
}
}

View file

@ -36,10 +36,24 @@ export const Feed = observer(function Feed({
return <FeedItem item={item} />
}
const onRefresh = () => {
view.refresh().catch(err => console.error('Failed to refresh', err))
view
.refresh()
.catch(err =>
view.rootStore.log.error(
'Failed to refresh notifications feed',
err.toString(),
),
)
}
const onEndReached = () => {
view.loadMore().catch(err => console.error('Failed to load more', err))
view
.loadMore()
.catch(err =>
view.rootStore.log.error(
'Failed to load more notifications',
err.toString(),
),
)
}
let data
if (view.hasLoaded) {

View file

@ -22,15 +22,15 @@ export const PostRepostedBy = observer(function PostRepostedBy({
useEffect(() => {
if (view?.params.uri === uri) {
console.log('Reposted by doing nothing')
return // no change needed? or trigger refresh?
}
console.log('Fetching Reposted by', uri)
const newView = new RepostedByViewModel(store, {uri})
setView(newView)
newView
.setup()
.catch(err => console.error('Failed to fetch reposted by', err))
.catch(err =>
store.log.error('Failed to fetch reposted by', err.toString()),
)
}, [uri, view?.params.uri, store])
const onRefresh = () => {

View file

@ -18,7 +18,14 @@ export const PostThread = observer(function PostThread({
const ref = useRef<FlatList>(null)
const posts = view.thread ? Array.from(flattenThread(view.thread)) : []
const onRefresh = () => {
view?.refresh().catch(err => console.error('Failed to refresh', err))
view
?.refresh()
.catch(err =>
view.rootStore.log.error(
'Failed to refresh posts thread',
err.toString(),
),
)
}
const onLayout = () => {
const index = posts.findIndex(post => post._isHighlightedPost)

View file

@ -72,12 +72,12 @@ export const PostThreadItem = observer(function PostThreadItem({
const onPressToggleRepost = () => {
item
.toggleRepost()
.catch(e => console.error('Failed to toggle repost', record, e))
.catch(e => store.log.error('Failed to toggle repost', e.toString()))
}
const onPressToggleUpvote = () => {
item
.toggleUpvote()
.catch(e => console.error('Failed to toggle upvote', record, e))
.catch(e => store.log.error('Failed to toggle upvote', e.toString()))
}
const onCopyPostText = () => {
Clipboard.setString(record.text)
@ -90,7 +90,7 @@ export const PostThreadItem = observer(function PostThreadItem({
Toast.show('Post deleted')
},
e => {
console.error(e)
store.log.error('Failed to delete post', e.toString())
Toast.show('Failed to delete post, please try again')
},
)

View file

@ -24,13 +24,13 @@ export const PostVotedBy = observer(function PostVotedBy({
useEffect(() => {
if (view?.params.uri === uri) {
console.log('Voted by doing nothing')
return // no change needed? or trigger refresh?
}
console.log('Fetching voted by', uri)
const newView = new VotesViewModel(store, {uri, direction})
setView(newView)
newView.setup().catch(err => console.error('Failed to fetch voted by', err))
newView
.setup()
.catch(err => store.log.error('Failed to fetch voted by', err.toString()))
}, [uri, view?.params.uri, store])
const onRefresh = () => {

View file

@ -47,7 +47,9 @@ export const Post = observer(function Post({
}
const newView = new PostThreadViewModel(store, {uri, depth: 0})
setView(newView)
newView.setup().catch(err => console.error('Failed to fetch post', err))
newView
.setup()
.catch(err => store.log.error('Failed to fetch post', err.toString()))
}, [initView, uri, view?.params.uri, store])
// deleted
@ -110,12 +112,12 @@ export const Post = observer(function Post({
const onPressToggleRepost = () => {
item
.toggleRepost()
.catch(e => console.error('Failed to toggle repost', record, e))
.catch(e => store.log.error('Failed to toggle repost', e.toString()))
}
const onPressToggleUpvote = () => {
item
.toggleUpvote()
.catch(e => console.error('Failed to toggle upvote', record, e))
.catch(e => store.log.error('Failed to toggle upvote', e.toString()))
}
const onCopyPostText = () => {
Clipboard.setString(record.text)
@ -128,7 +130,7 @@ export const Post = observer(function Post({
Toast.show('Post deleted')
},
e => {
console.error(e)
store.log.error('Failed to delete post', e.toString())
Toast.show('Failed to delete post, please try again')
},
)

View file

@ -23,7 +23,9 @@ export const PostText = observer(function PostText({
}
const newModel = new PostModel(store, uri)
setModel(newModel)
newModel.setup().catch(err => console.error('Failed to fetch post', err))
newModel
.setup()
.catch(err => store.log.error('Failed to fetch post', err.toString()))
}, [uri, model?.uri, store])
// loading

View file

@ -53,10 +53,21 @@ export const Feed = observer(function Feed({
}
}
const onRefresh = () => {
feed.refresh().catch(err => console.error('Failed to refresh', err))
feed
.refresh()
.catch(err =>
feed.rootStore.log.error(
'Failed to refresh posts feed',
err.toString(),
),
)
}
const onEndReached = () => {
feed.loadMore().catch(err => console.error('Failed to load more', err))
feed
.loadMore()
.catch(err =>
feed.rootStore.log.error('Failed to load more posts', err.toString()),
)
}
let data
if (feed.hasLoaded) {

View file

@ -69,12 +69,12 @@ export const FeedItem = observer(function ({
const onPressToggleRepost = () => {
item
.toggleRepost()
.catch(e => console.error('Failed to toggle repost', record, e))
.catch(e => store.log.error('Failed to toggle repost', e.toString()))
}
const onPressToggleUpvote = () => {
item
.toggleUpvote()
.catch(e => console.error('Failed to toggle upvote', record, e))
.catch(e => store.log.error('Failed to toggle upvote', e.toString()))
}
const onCopyPostText = () => {
Clipboard.setString(record.text)
@ -87,7 +87,7 @@ export const FeedItem = observer(function ({
Toast.show('Post deleted')
},
e => {
console.error(e)
store.log.error('Failed to delete post', e.toString())
Toast.show('Failed to delete post, please try again')
},
)

View file

@ -23,15 +23,15 @@ export const ProfileFollowers = observer(function ProfileFollowers({
useEffect(() => {
if (view?.params.user === name) {
console.log('User followers doing nothing')
return // no change needed? or trigger refresh?
}
console.log('Fetching user followers', name)
const newView = new UserFollowersViewModel(store, {user: name})
setView(newView)
newView
.setup()
.catch(err => console.error('Failed to fetch user followers', err))
.catch(err =>
store.log.error('Failed to fetch user followers', err.toString()),
)
}, [name, view?.params.user, store])
const onRefresh = () => {

View file

@ -23,15 +23,15 @@ export const ProfileFollows = observer(function ProfileFollows({
useEffect(() => {
if (view?.params.user === name) {
console.log('User follows doing nothing')
return // no change needed? or trigger refresh?
}
console.log('Fetching user follows', name)
const newView = new UserFollowsViewModel(store, {user: name})
setView(newView)
newView
.setup()
.catch(err => console.error('Failed to fetch user follows', err))
.catch(err =>
store.log.error('Failed to fetch user follows', err.toString()),
)
}, [name, view?.params.user, store])
const onRefresh = () => {

View file

@ -52,7 +52,7 @@ export const ProfileHeader = observer(function ProfileHeader({
}`,
)
},
err => console.error('Failed to toggle follow', err),
err => store.log.error('Failed to toggle follow', err.toString()),
)
}
const onPressEditProfile = () => {
@ -94,7 +94,7 @@ export const ProfileHeader = observer(function ProfileHeader({
await view.muteAccount()
Toast.show('Account muted')
} catch (e: any) {
console.error(e)
store.log.error('Failed to mute account', e.toString())
Toast.show(`There was an issue! ${e.toString()}`)
}
}
@ -103,7 +103,7 @@ export const ProfileHeader = observer(function ProfileHeader({
await view.unmuteAccount()
Toast.show('Account unmuted')
} catch (e: any) {
console.error(e)
store.log.error('Failed to unmute account', e.toString())
Toast.show(`There was an issue! ${e.toString()}`)
}
}

View file

@ -16,13 +16,13 @@ export const ProfileMembers = observer(function ProfileMembers({
useEffect(() => {
if (view?.params.actor === name) {
console.log('Members doing nothing')
return // no change needed? or trigger refresh?
}
console.log('Fetching members', name)
const newView = new MembersViewModel(store, {actor: name})
setView(newView)
newView.setup().catch(err => console.error('Failed to fetch members', err))
newView
.setup()
.catch(err => store.log.error('Failed to fetch members', err.toString()))
}, [name, view?.params.actor, store])
const onRefresh = () => {

View file

@ -45,8 +45,7 @@ export const ViewHeader = observer(function ViewHeader({
}
const onPressReconnect = () => {
store.session.connect().catch(e => {
// log for debugging but ignore otherwise
console.log(e)
store.log.warn('Failed to reconnect to server', e)
})
}
if (typeof canGoBack === 'undefined') {