zio/bsky-app
2
0
Fork 0
Code Pull requests Releases Packages Activity

Update hint for notifications

Browse source
This commit is contained in:
renahlee 2023-05-16 22:31:59 -07:00
parent 562faa76cc
commit f7f0db65d3
2 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/view/shell/Drawer.tsx
View file

@ -222,7 +222,11 @@ export const DrawerContent = observer(() => {
} }
label="Notifications" label="Notifications"
accessibilityLabel="Notifications" accessibilityLabel="Notifications"
accessibilityHint={`${store.me.notifications.unreadCountLabel} unread`} accessibilityHint={
notifications.unreadCountLabel === ''
? 'No new notifications'
: `${notifications.unreadCountLabel} unread`
}
count={notifications.unreadCountLabel} count={notifications.unreadCountLabel}
bold={isAtNotifications} bold={isAtNotifications}
onPress={onPressNotifications} onPress={onPressNotifications}

9
src/view/shell/bottom-bar/BottomBar.tsx
View file

@ -38,6 +38,7 @@ export const BottomBar = observer(({navigation}: BottomTabBarProps) => {
useNavigationTabState() useNavigationTabState()
const {footerMinimalShellTransform} = useMinimalShellMode() const {footerMinimalShellTransform} = useMinimalShellMode()
const {notifications} = store.me
const onPressTab = React.useCallback( const onPressTab = React.useCallback(
(tab: string) => { (tab: string) => {
@ -138,11 +139,15 @@ export const BottomBar = observer(({navigation}: BottomTabBarProps) => {
) )
} }
onPress={onPressNotifications} onPress={onPressNotifications}
notificationCount={store.me.notifications.unreadCountLabel} notificationCount={notifications.unreadCountLabel}
accessible={true} accessible={true}
accessibilityRole="tab" accessibilityRole="tab"
accessibilityLabel="Notifications" accessibilityLabel="Notifications"
accessibilityHint={`${store.me.notifications.unreadCountLabel} unread`} accessibilityHint={
notifications.unreadCountLabel === ''
? 'No new notifications'
: `${notifications.unreadCountLabel} unread`
}
/> />
<Btn <Btn
testID="bottomBarProfileBtn" testID="bottomBarProfileBtn"