Revert "Make settings account buttons a little nicer" (#4987)

src/view/com/util/AccountDropdownBtn.tsx

@@ -1,59 +1,53 @@
 import React from 'react'
-import {msg, Trans} from '@lingui/macro'
+import {Pressable} from 'react-native'
+import {
+  FontAwesomeIcon,
+  FontAwesomeIconStyle,
+} from '@fortawesome/react-native-fontawesome'
+import {msg} from '@lingui/macro'
 import {useLingui} from '@lingui/react'
 
 import {SessionAccount, useSessionApi} from '#/state/session'
-import {HITSLOP_10} from 'lib/constants'
+import {usePalette} from 'lib/hooks/usePalette'
-import {Button, ButtonIcon} from '#/components/Button'
+import {s} from 'lib/styles'
 import {useDialogControl} from '#/components/Dialog'
-import {DotGrid_Stroke2_Corner0_Rounded as Ellipsis} from '#/components/icons/DotGrid'
-import {Trash_Stroke2_Corner0_Rounded as Trash} from '#/components/icons/Trash'
-import * as Menu from '#/components/Menu'
 import * as Prompt from '#/components/Prompt'
 import * as Toast from '../../com/util/Toast'
+import {DropdownItem, NativeDropdown} from './forms/NativeDropdown'
 
 export function AccountDropdownBtn({account}: {account: SessionAccount}) {
-  const {_} = useLingui()
+  const pal = usePalette('default')
   const {removeAccount} = useSessionApi()
   const removePromptControl = useDialogControl()
+  const {_} = useLingui()
 
+  const items: DropdownItem[] = [
+    {
+      label: _(msg`Remove account`),
+      onPress: removePromptControl.open,
+      icon: {
+        ios: {
+          name: 'trash',
+        },
+        android: 'ic_delete',
+        web: ['far', 'trash-can'],
+      },
+    },
+  ]
   return (
     <>
-      <Menu.Root>
+      <Pressable accessibilityRole="button" style={s.pl10}>
-        <Menu.Trigger label={_(`Account options`)}>
+        <NativeDropdown
-          {({props}) => {
-            return (
-              <Button
-                {...props}
           testID="accountSettingsDropdownBtn"
-                label={_(`Account options`)}
+          items={items}
-                hitSlop={HITSLOP_10}
+          accessibilityLabel={_(msg`Account options`)}
-                size="xsmall"
+          accessibilityHint="">
-                shape="round"
+          <FontAwesomeIcon
-                color="secondary"
+            icon="ellipsis-h"
-                variant="ghost">
+            style={pal.textLight as FontAwesomeIconStyle}
-                <ButtonIcon icon={Ellipsis} size="sm" />
+          />
-              </Button>
+        </NativeDropdown>
-            )
+      </Pressable>
-          }}
-        </Menu.Trigger>
-
-        <Menu.Outer style={{minWidth: 170}}>
-          <Menu.Group>
-            <Menu.Item
-              label={_(msg`Remove account`)}
-              onPress={() => {
-                removePromptControl.open()
-              }}>
-              <Menu.ItemText>
-                <Trans>Remove account</Trans>
-              </Menu.ItemText>
-              <Menu.ItemIcon icon={Trash} />
-            </Menu.Item>
-          </Menu.Group>
-        </Menu.Outer>
-      </Menu.Root>
-
       <Prompt.Basic
         control={removePromptControl}
         title={_(msg`Remove from quick access?`)}

src/view/screens/Settings/index.tsx

@@ -18,7 +18,6 @@ import {useLingui} from '@lingui/react'
 import {useFocusEffect, useNavigation} from '@react-navigation/native'
 import {useQueryClient} from '@tanstack/react-query'
 
-import {sanitizeHandle} from '#/lib/strings/handles'
 import {isNative} from '#/platform/detection'
 import {useModalControls} from '#/state/modals'
 import {clearStorage} from '#/state/persisted'
@@ -56,11 +55,8 @@ import {UserAvatar} from 'view/com/util/UserAvatar'
 import {ScrollView} from 'view/com/util/Views'
 import {DeactivateAccountDialog} from '#/screens/Settings/components/DeactivateAccountDialog'
 import {atoms as a, useTheme} from '#/alf'
-import {Button, ButtonContext} from '#/components/Button'
 import {useDialogControl} from '#/components/Dialog'
 import {BirthDateSettingsDialog} from '#/components/dialogs/BirthDateSettings'
-import {Link as NewLink} from '#/components/Link'
-import {Text as NewText} from '#/components/Typography'
 import {Email2FAToggle} from './Email2FAToggle'
 import {ExportCarDialog} from './ExportCarDialog'
 
@@ -76,69 +72,62 @@ function SettingsAccountCard({
     logContext: 'Settings',
   ) => void
 }) {
+  const pal = usePalette('default')
   const {_} = useLingui()
   const t = useTheme()
   const {currentAccount} = useSession()
   const {data: profile} = useProfileQuery({did: account.did})
   const isCurrentAccount = account.did === currentAccount?.did
 
-  const contents = (ctx: ButtonContext) => (
+  const contents = (
     <View
       style={[
-        a.w_full,
+        pal.view,
-        a.flex_row,
+        styles.linkCard,
-        a.align_center,
+        account.did === pendingDid && t.atoms.bg_contrast_25,
-        a.gap_md,
-        a.py_md,
-        t.atoms.bg,
-        {
-          paddingHorizontal: 18,
-          marginBottom: 1,
-        },
-        account.did === pendingDid && [t.atoms.bg_contrast_25],
-        ctx.pressed && [t.atoms.bg_contrast_25],
       ]}>
+      <View style={styles.avi}>
         <UserAvatar
           size={40}
           avatar={profile?.avatar}
           type={profile?.associated?.labeler ? 'labeler' : 'user'}
         />
-      <View style={[a.flex_1]}>
+      </View>
-        <NewText
+      <View style={[s.flex1]}>
-          style={[a.text_md, a.font_bold, a.leading_tight]}
+        <Text type="md-bold" style={[pal.text, a.self_start]} numberOfLines={1}>
-          numberOfLines={1}>
           {profile?.displayName || account.handle}
-        </NewText>
+        </Text>
-        <NewText
+        <Text type="sm" style={pal.textLight} numberOfLines={1}>
-          style={[t.atoms.text_contrast_medium, a.leading_tight]}
+          {account.handle}
-          numberOfLines={1}>
+        </Text>
-          {sanitizeHandle(account.handle, '@')}
-        </NewText>
       </View>
       <AccountDropdownBtn account={account} />
     </View>
   )
 
   return isCurrentAccount ? (
-    <NewLink
+    <Link
-      to={makeProfileLink({
+      href={makeProfileLink({
         did: currentAccount?.did,
         handle: currentAccount?.handle,
       })}
-      label={_(msg`Your profile`)}
+      title={_(msg`Your profile`)}
-      style={[a.w_full]}>
+      noFeedback>
       {contents}
-    </NewLink>
+    </Link>
   ) : (
-    <Button
+    <TouchableOpacity
       testID={`switchToAccountBtn-${account.handle}`}
+      key={account.did}
       onPress={
         pendingDid ? undefined : () => onPressSwitchAccount(account, 'Settings')
       }
-      label={_(msg`Switch to ${account.handle}`)}
+      accessibilityRole="button"
-      style={[a.w_full]}>
+      accessibilityLabel={_(msg`Switch to ${account.handle}`)}
+      accessibilityHint={_(msg`Switches the account you are logged in to`)}
+      activeOpacity={0.8}>
       {contents}
-    </Button>
+    </TouchableOpacity>
   )
 }