* use <Modal> to display composer
* trigger `onPressCancel` on modal cancel
* remove android top padding
* use light statusbar on ios
* use KeyboardStickyView from r-n-keyboard-controller
* make extra bottom padding ios-only
* make cancelRef optional
* scope legacy modals
* don't change bg color on ios
* use fullScreen instead of formSheet
* adjust padding on keyboardaccessory to account for new buttons
* Revert "use KeyboardStickyView from r-n-keyboard-controller"
This reverts commit 426c812904f427bdd08107cffc32e4be1d9b83bc.
* fix insets
* tweaks and merge
* revert 89f51c72
* nit
* import keyboard provider
---------
Co-authored-by: Hailey <me@haileyok.com>
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
* Update PostAlerts rendering to show the avi of the labeler rather than the display name; also add size variations
* Update ProfileHeaderAlerts to match PostAlerts behavior
* always show header on native
* ALF ALF ALF
* rm offset for top border
* wrap in a `CenteredView`
* use `CenteredView`'s side borders
* account for loading state on web
* move `isTabletOrMobile`
* hide top border on first post in list
* show border if parents are loading
* don't show top border for deleted or blocked posts
* hide top border for hidden replies
* Rm root post top border
---------
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
* add prop to `ListImpl` for `content-visibility` style
* change to `disableContentVisibility`
* lint
* tweaks
* Keep the fix more general
* Clarify ambiguity
---------
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
* alf the repost dropdown on web + import icons
* alf like icon
* convert other post controls
* add missing padding to share button
* refine buttons and use better icons
* revert buttonicon changes
* remove ButtonIcon and ButtonText from repost dialog
* use 15px font size when not big
* reduce size and use contrast_25
* add hover state to logged out view
* add `userSelect: 'none'` to buttons
* use width rather than height
* fix quote close behaviour
* prettier
* Fix Esc on repost
* Use new icons for placeholder
* Fix placeholder
---------
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
* translation expo module
* add `onClose` and `onReplacementAction`
* rm onReplacementAction
* make all props published
* make translation api available globally w/o wrapper (#4110)
* conditionally import the translation module
* only use native translation if language is probably supported
* open native translation via dropdown menu
---------
Co-authored-by: Hailey <me@haileyok.com>
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
* Dont show account or profile alerts and informs on posts
* Sort threads to put blurred items at bottom
* Group blurred replies under a single 'show hidden replies' control
* Distinguish between muted and hidden replies in the thread view
* Fix types
* Modify the label alerts with some minor aesthetic updates and to show the source of a label
* Tune when an account-level alert is shown on a post
* Revert: show account-level alerts on posts again
* Rm unused import
* Fix to showing hidden replies when viewing a blurred item
* Go ahead and uncover replies when 'show hidden posts' is clicked
---------
Co-authored-by: dan <dan.abramov@gmail.com>
* add checkbox to create privileged app password
* add indicator to privileged app pwds to list
* bump api
* oops missed the yarnlock
* adjust modal padding
* lowercase
* one more lowercase
---------
Co-authored-by: Hailey <me@haileyok.com>
* remove unnecessary `getProfile()` calls from feed load
add comments
ensure only if first
simplify
nit
handle cases where the parent is removed
add a comment
remove unnecessary `getProfile()` calls from feed load
limit only to the first post in the returned items
move the logic out of the render and into the query
add the grandparent properly
update `FeedItem`
bump package
update `FeedItem`
update `post-feed` query
update `FeedSlice`
* nit
* simplify logic
* always pass `parentAuthor`
* oops!
* update `DebugMod`
* add profile button
* separate out button to component
* normalise subscribe to labeller button size
* infinite staletime
* use Link rather than Button and change icon
* adjust icon position
* Revert "[🐴] Ensure keyboard gets dismissed when leaving screen (#4104)"
This reverts commit 3ca671d9aa.
* getting somewhere
* remove some now nuneeded code
* fully implement keyboard controller
* onStartReached check
* fix new messages pill alignment
* scroll to end on press
* simplify pill scroll logic
* update comment
* adjust logic on when to hide the pill
* fix backgrounding jank
* improve look of deleting messages
* add double tap on messages
* better onStartReached logic
* nit
* add hit slop to the gesture
* better gestures for press and hold
* nits
* Make feeds easier to reorder
* Add reorder e2e test
* Tweak feed card to only allow one line (#4002)
---------
Co-authored-by: Eric Bailey <git@esb.lol>
* `flexShrink` on iOS and web
`flexShrink` on iOS and web
`flexShrink` on iOS and web
actually, `flexShrink`
use `flex`
* adjust web
* `expect-error` `onMouseUp`
* ignore ref type check
* Lower seen threshold to 1.5s
* Send feedContext for replies
* Use a simpler and more reliable feedContext fallback
---------
Co-authored-by: Paul Frazee <pfrazee@gmail.com>
* Handle home algo with backwards compat
* Remove todo, fix pwi view
* Simplify filter logic
* Handle edge case
* Handle home algo in FeedSourceCard
* Fix handling of pinned feed if home algo is disabled
* Handle home algo on ProfileFeed screen
* Rename
* Fix pinned feeds key
* Improve perf of pinned feeds with primary algo
* Update statsig API
* Revert unneeded changes
* Support following feed as well
* Better formatting
* Clarify primary algo usage
* Better comment
* Handle saved feed screen edge case
* Restore Feeds sparkle, fix line height
* Move gate call down
* Filter out primary algo from feeds page
* Filter dupe from Feeds screen
* Simplify logic
* Missing following handling
* Hide primary feed setting outside exp
* Revert testing change
* Migrate usePinnedFeedInfos
* Migrate FeedSourceCard
* Migrate Feeds screen
* Migrate SavedFeeds screen
* Handle timeline in feed infos
* Finish migrating ProfileFeed, FeedSourceCard
* Migrate ProfileList
* Finalize mutation hooks
* Allow unsaving lists
* Handle following feed on Feeds screen
* Handle following on SavedFeeds
* Get rid of deprecated interface usages
* Handle no pinned feeds
* Handle no feeds on Feeds screen
* Reuse component on SavedFeeds screen
* Handle no following feed
* Remove primary algo references
* Migrate to new plural APIs
* Remove unused event
* Prevent duplicate keys
* Make handling much more clear
* Dedupe useHeaderOffset
* Filter unknown feed types at source
* Use just following
* Immprove key handling
* Resume from last tab
* Bump sdk
* Revert Gemfile
* Additional protection in FeedSourceCard
* Fix ProfileList save/unsave handling
* Translate
* Translate
* Match existing handling post-signup
* Ensure onboarding results in correct selected feeds
* Some testing tweaks on create/onboarding
* Revert primary algo consderations
* Remove comment
* Handle default feed setting
* Rm unnecessary type cast
* Remove premature gate check
* Remove nullable check in onPageSelecting, assume the pager checks bounds
* Use null for default selected feed
* Rm unrelated change
* Remove the concept of __key__
I don't think this concept is consistent.
It's introduced on FeedSourceInfo which is used both by pinned feeds and by useFeedSourceInfoQuery. Pinned feeds use the pinning ID there. But there is no pinning ID for useFeedSourceInfoQuery. So this means this field is sometimes one thing and sometimes some other thing. That is a decent sign that it shouldn't be on that type at all.
It's not used anywhere except the desktop feed enumeration. It seems reasonable to assume there that we wouldn't want to show the same feed URL twice. (And if it does occur in the array twice, IMO we should solve that at the API level and dedupe it on read or next write.) So I think we should just use the URL in that place. (I used the descriptor, which is equivalent.)
* Dedupe pinned feeds by URL on read
* Filter timeline out of mergefeed sources
* Put FeedDescriptor into FeedSourceInfo
* Group saved info with feed for pins
This removes a loop within a loop within a loop.
* Fix Feeds link on native
---------
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
